[MITgcm-support] Bug in Darwin code?

[Martin Losch]

Hi Stefano,

darwin is absolutely not my code and there is no guarantee that  
anything in the MITgcm_contrib area works properly from the very  
start, but I think you are right, it should be (i,j,..). I think its a  
leftover from a subroutine call, where sometimes the ptracers fields  
need to be referenced like this in the actual parameter list (see eg.  
pkg/ptracers/ptracers_impldiff.F).

M.

On Nov 4, 2009, at 6:59 PM, Stefano Querin wrote:

> Dear MITgcmers,
>
> I and my colleague Gianpiero Cossarini are setting up a model for  
> studying dense water formation processes and air/sea CO2 exchanges  
> in shelf areas (northern Adriatic Sea).
> To accomplish this, we are modifying the darwin package ( / 
> MITgcm_contrib/darwin/pkg/darwin ), still in development.
>
> We just would like to report a possible error in the code.
> In particular, we refer to the routine dic_surfforcing_init.F (lines  
> 217, 219, 221, 223).
> The first two indexes of the variable Ptracer should be "i" and  
> "j" (varying within the cycle) instead of "1-Olx" and "1-Oly".
>
> GC observed that this error can make the model crash at startup (if  
> Ptracer(1-Olx,1-Oly, ...) is equal to 0) or it can be "skipped"  
> without consequences (if Ptracer(1-Olx,1-Oly, ...) is by chance  
> different from 0). This depends on the shape of the bathymetry.
>
> Thanks!
>
> Cheers,
>
> Stefano
>
>
> _______________________________________________
> MITgcm-support mailing list
> MITgcm-support at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-support