[Mitgcm-support] bug in gad_advection.F ?

[mitgcm-support at dev.mitgcm.org]

In gad_advection there are the following lines:

      IF (useCubedSphereExchange) THEN
       nipass=3
      ELSE
       nipass=1
      ENDIF
       nipass=1

Is the last line (unconditional nipass=1) intended?

Also, there's an issue with the multi-dimensional advection scheme.
It's ipass loop requires storing to a new type of common blocks.
This can be done, but in the absence of an #ifdef
this common block will ALWAYS be created, thus unnecessarily
increasing the code size if multiDimAdvection is not wanted.

Patrick

_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/

Patrick Heimbach                        FON: +1 / 617 / 253-5259
Massachusetts Institute of Technology   FAX: +1 / 617 / 253-4464 
EAPS, Room 54-1518
77 Massachusetts Avenue                  mailto:heimbach at mit.edu
Cambridge MA 02139, U.S.A.         http://www.mit.edu/~heimbach/

>>>>>>>      http://web.mit.edu/cms/reconstructions      <<<<<<<