[MITgcm-devel] mypackage_calc_rhs.F

[Jean-Michel Campin]

Hi Dimitris,

On Sat, Aug 06, 2011 at 07:51:01AM -0700, Dimitris Menemenlis wrote:
> Got stuck between steps 1 and 2 last night for some reason.
> Will get back to this later today.
No problems. I also missed few emails yesterday (including this one).

> 
> Incidentally I noticed following lines in mypackage_diagnostics_state.F
> 
> #ifdef ALLOW_MYPACKAGE
> #include "MYPACKAGE.h"
> #endif
> 
> I think that the #ifdef/#endif may be a carryover from when this bit of
> code lived outside pkg/mypackage ?
> It's harmless but since mypackage is supposed to be the poster child
> package of MITgcm, it would be good to remove if it is not needed.
> 
> Let me know if this #ifdef/#endif is spurious and if OK to remove.
> 
I tend to prefer the way it was (with #ifdef ALLOW_MYPACKAGE around
#include "MYPACKAGE.h") since all this S/R is almost empty (every thing
within #ifdef ALLOW_MYPACKAGE) when ALLOW_MYPACKAGE is undef.
In practice, it (should) allows me to have a local copy of mypackage_diagnostics_state.F
in my code dir (+MYPACKAGE_OPTIONS.h), and still be able to compile with
or without mypackage in code/packages.conf 
And for a type of modular pkg like mypackage, might be something
we want to maintain. But it's more an open question.
And for this reason, I would not put back now the #ifdef ALLOW_MYPACKAGE
in mypackage_diagnostics_state.F, will see later on.

Cheers,
Jean-Michel

> D.
> 
> On Sat, 2011-08-06 at 07:25 -0700, Jean-Michel Campin wrote:
> > Hi Dimitris,
> > 
> > Yes, sounds a good plan.
> > Cheers,
> > Jean-Michel
> > 
> > On Fri, Aug 05, 2011 at 06:29:27PM -0700, Menemenlis, Dimitris (3248)
> > wrote:
> > > Jean-Michel, sorry I got distracted.
> > > 
> > > I will proceed in four steps.
> > > 
> > > 1) I will modify in contrib to be sure I can reproduce verification
> > experiment in contrig with bi/bj loop.
> > > 
> > > 2) I will add pkg/bbl  -  the verification experiment will remain in
> > contrib
> > > 
> > > 3)  I will modify one of the existing verif experiments, so we don't
> > have to recompile the code one more
> > > time but leave the verif experiment in the notes and point to it
> > from documentation
> > > 
> > > 4) add description of package to documentation
> 
> 
> 
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel