[MITgcm-devel] mypackage_calc_rhs.F

Menemenlis, Dimitris (3248) Dimitris.Menemenlis at jpl.nasa.gov
Sun Aug 7 23:55:14 EDT 2011


Jean-Michel, regarding verification experiment for bbl,
would it be OK to just turn on useBBL in one of the existing
set-ups, e.g., the baseline or the seaice global_ocean.cs32x15.
That way there is no additional test integrations needed.
This would mean that I have to change output.txt or output.seaice.txt
Let me know if OK to proceed as above or if you prefer that
I add one more input directory and output file.

Regarding discussion below, I will leave as is until you
have decided how you want to proceed.
If the reason for carrying the spurious #ifdef ALLOW_MYPACKAGE
is for local copy of code, then do we need to carry it in the main branch?

Cheers

Dimitris Menemenlis

On Aug 7, 2011, at 9:25 AM, Jean-Michel Campin wrote:

> I tend to prefer the way it was (with #ifdef ALLOW_MYPACKAGE around
> #include "MYPACKAGE.h") since all this S/R is almost empty (every thing
> within #ifdef ALLOW_MYPACKAGE) when ALLOW_MYPACKAGE is undef.
> In practice, it (should) allows me to have a local copy of mypackage_diagnostics_state.F
> in my code dir (+MYPACKAGE_OPTIONS.h), and still be able to compile with
> or without mypackage in code/packages.conf 
> And for a type of modular pkg like mypackage, might be something
> we want to maintain. But it's more an open question.
> And for this reason, I would not put back now the #ifdef ALLOW_MYPACKAGE
> in mypackage_diagnostics_state.F, will see later on.




More information about the MITgcm-devel mailing list