[MITgcm-devel] mypackage_calc_rhs.F

[Patrick Heimbach]

Indeed looks like legacy stuff,
and OK to remove, I'd say.
-p.

On Aug 6, 2011, at 10:51 AM, Dimitris Menemenlis wrote:

> Got stuck between steps 1 and 2 last night for some reason.
> Will get back to this later today.
> 
> Incidentally I noticed following lines in mypackage_diagnostics_state.F
> 
> #ifdef ALLOW_MYPACKAGE
> #include "MYPACKAGE.h"
> #endif
> 
> I think that the #ifdef/#endif may be a carryover from when this bit of
> code lived outside pkg/mypackage ?
> It's harmless but since mypackage is supposed to be the poster child
> package of MITgcm, it would be good to remove if it is not needed.
> 
> Let me know if this #ifdef/#endif is spurious and if OK to remove.
> 
> D.
> 
> On Sat, 2011-08-06 at 07:25 -0700, Jean-Michel Campin wrote:
>> Hi Dimitris,
>> 
>> Yes, sounds a good plan.
>> Cheers,
>> Jean-Michel
>> 
>> On Fri, Aug 05, 2011 at 06:29:27PM -0700, Menemenlis, Dimitris (3248)
>> wrote:
>>> Jean-Michel, sorry I got distracted.
>>> 
>>> I will proceed in four steps.
>>> 
>>> 1) I will modify in contrib to be sure I can reproduce verification
>> experiment in contrig with bi/bj loop.
>>> 
>>> 2) I will add pkg/bbl  -  the verification experiment will remain in
>> contrib
>>> 
>>> 3)  I will modify one of the existing verif experiments, so we don't
>> have to recompile the code one more
>>> time but leave the verif experiment in the notes and point to it
>> from documentation
>>> 
>>> 4) add description of package to documentation
> 
> 
> 
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel

---
Patrick Heimbach | heimbach at mit.edu | http://www.mit.edu/~heimbach
MIT | EAPS 54-1420 | 77 Massachusetts Ave | Cambridge MA 02139 USA
FON +1-617-253-5259 | FAX +1-617-253-4464 | SKYPE patrick.heimbach