[MITgcm-devel] exf runoff and seaice

[Jean-Michel Campin]

Hi Dimitris,

In the EXF pkg, I am going to replace all the:
#if defined (ALLOW_RUNOFF) || defined (ALLOW_SEAICE)
by just
#ifdef ALLOW_RUNOFF

1) it's not clean.
 (we have some EXF stuff in pkg/seaice, it's documented and
 it's fine ; but I prefer to keep exf without any seaice CPP options)
2) it's not right, because those "|| defined (ALLOW_SEAICE)"
 are missing in a significant number of places in pkg/exf
3) if this is needed, there are other ways to do it,
 the simplest would be to check in seaice_check.F that 
 ALLOW_RUNOFF is defined (like what is done for ALLOW_ATM_TEMP, 
 ALLOW_DOWNWARD_RADIATION ... etc)

Is it OK like this ?

I am trying to get a set-up running with exf that would be 
somehow "consistent", and after ~ 20 attempts, still haven't 
figured out what the runoff is doing.

Cheers,
Jean-Michel