[MITgcm-devel] another bug in growth.F ?

[Patrick Heimbach]

Dimitris,

go ahead and check in. I'll fix adjoint afterwards.
J.M. is in France right now, but wouldn't care too much,
I guess, since he thinks that whole code is flawed anyways.

(I realized Martin's EmPmR fix in growth isn't
checked in yet either, is that right).

-p.



On Mon, 2006-11-06 at 09:59 -0800, Dimitris Menemenlis wrote:
> Jinlun, thank you for confirmation.
> 
> Patrick, Martin, and Jean-Michel, this will break lab-sea experiment ... and 
> possibly the adjoint, but these are bug fixes so they are urgent.  Can I go 
> ahead and submit, along with Martin and Jinlun's changes for HSNOW treatment?
> 
> A version of the modified growth.F that I would check in is here:
> http://mitgcm.org/cgi-bin/viewcvs.cgi/MITgcm_contrib/high_res_cube/code-mods/growth.F
> 
> Dimitris
> 
> 
> > Dimitris, go ahead removing it from 1 and 2. Jinlun
> > 
> > Dimitris Menemenlis wrote:
> > 
> >> Jinlun, thanks for getting back.  Can the A22 (0.15) minimum be removed
> >> from all computations in growth.F and groatb.F?  There are three places
> >> that are affected by A22:
> >> 
> >> 1. Computation of hsnow, precip, and evap in growth.F.  It definitely needs
> >> to be removed from there as this introduces an artificial forcing bias in
> >> the solution, even over fully-open-water regions.
> >> 
> >> 2. Computation of GAREA in growth.F.  I think that it should be removed
> >> from there too but am not 100% sure.
> >> 
> >> 3. Computation of ice thickness HICE in groatb.F.  Removing it from there
> >> would cause code to blow up since AREA(I,J,2,bi,bj) is in the denominator.
> >> 
> >> Should I go ahead and remove from 1 and 2 above but leave as is in 3?
> >> 
> >> Dimitris
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel
-- 
Patrick Heimbach | heimbach at mit.edu | http://www.mit.edu/~heimbach
MIT | EAPS 54-1518 | 77 Massachusetts Ave | Cambridge MA 02139 USA
FON +1-617-253-5259 | FAX +1-617-253-4464 | SKYPE patrick.heimbach