[MITgcm-devel] new pkg/matrix checked in

Ed Hill ed at eh3.com
Mon Apr 18 16:53:52 EDT 2005


On Mon, 2005-04-18 at 16:27 -0400, samar khatiwala wrote:
> 
> JMC: Ed said that you would go over these file to see if they meet your
> exacting standards, and whether, once incorporated into the main tree,
> they pass the test suite.

Hi Samar,

Honestly, I _cannot_ volunteer Jean-Michel.  ;-)

So perhaps the best way to phrase it is: "we ought to review your code
and Jean-Michel is probably the most thorough MITgcm reviewer--so please
ask him politely to take a look!"


> I don't, as yet, have a compact, fully functional example (the ones I have
> are rather involved), so the rest of the directories in
> verification/matrix_example are empty. But I should have something there
> soon.

It would be really helpful if you could generate and check in a test
that uses your "matrix" package.

For instance, I've noticed a few non-portable things (eg. Fortran lines
w/>72 characters) that I'll fix as soon as you have a working example in
verification.  As it is, I don't want to change anything if there isn't
a way to test it.

Ed

-- 
Edward H. Hill III, PhD
office:  MIT Dept. of EAPS;  Rm 54-1424;  77 Massachusetts Ave.
             Cambridge, MA 02139-4307
emails:  eh3 at mit.edu                ed at eh3.com
URLs:    http://web.mit.edu/eh3/    http://eh3.com/
phone:   617-253-0098
fax:     617-253-4464




More information about the MITgcm-devel mailing list