[MITgcm-devel] imin,... halos for convective_adjustment

[Patrick Heimbach]

Hi,

there seems to be an inconsistency (bug)
in array boundaries between 
"top level" routine convective_adjustment
which when called from the_correction_step
obtains
         iMin = 1
        iMax = sNx
        jMin = 1
        jMax = sNy
and the lower (or upper?) routines
convective_weights, convectively_mixtracer etc.

The latter compute on the enitre domain including halos
but find_rho only computes rhoK, rhoKm1 in the interior only,
and rhoK, rhoKm1 is never initialized.
It might be benign, but some performance analysis tools,
e.g. ftrace on NEC choke on this.

So either all lower routines get halo computations removed
or imin,... need to be re-changed
(they used include halos up to version 1.19).

-Patrick



--------------------------------------------------------
Patrick Heimbach   Massachusetts Institute of Technology
FON: +1/617/253-5259                  EAPS, Room 54-1518
FAX: +1/617/253-4464             77 Massachusetts Avenue
mailto:heimbach at mit.edu               Cambridge MA 02139
http://www.mit.edu/~heimbach/                        USA