[MITgcm-devel] imin,... halos for convective_adjustment

[Ed Hill]

On Thu, 2004-08-05 at 16:15, Patrick Heimbach wrote:
> Hi,
> 
> there seems to be an inconsistency (bug)
> in array boundaries between 
> "top level" routine convective_adjustment
> which when called from the_correction_step
> obtains
>          iMin = 1
>         iMax = sNx
>         jMin = 1
>         jMax = sNy
> and the lower (or upper?) routines
> convective_weights, convectively_mixtracer etc.
> 
> The latter compute on the enitre domain including halos
> but find_rho only computes rhoK, rhoKm1 in the interior only,
> and rhoK, rhoKm1 is never initialized.
> It might be benign, but some performance analysis tools,
> e.g. ftrace on NEC choke on this.
> 
> So either all lower routines get halo computations removed
> or imin,... need to be re-changed
> (they used include halos up to version 1.19).


Hi Patrick,

I saw these iMin,iMax,jMin,jMax inconsistencies in many of the EoS
routines.  Even if they are "harmless" (as you point out), its still
very misleading to pass them around and then ignore them at the lower
levels!

Ed

-- 
Edward H. Hill III, PhD
office:  MIT Dept. of EAPS;  Rm 54-1424;  77 Massachusetts Ave.
             Cambridge, MA 02139-4307
emails:  eh3 at mit.edu                ed at eh3.com
URLs:    http://web.mit.edu/eh3/    http://eh3.com/
phone:   617-253-0098
fax:     617-253-4464