[MITgcm-support] Problem with MNC masking of ice shelf diagnostics

[Naughten, Kaitlin A.]

Thanks very much Ed. I've opened an issue here: https://github.com/MITgcm/MITgcm/issues/97

________________________________
From: MITgcm-support <mitgcm-support-bounces at mitgcm.org> on behalf of Edward W Doddridge <ewd at mit.edu>
Sent: 08 May 2018 21:41:39
To: mitgcm-support at mitgcm.org
Subject: Re: [MITgcm-support] Problem with MNC masking of ice shelf diagnostics

Hi Kaitlin,

Thanks for taking the time to report this, and to track down what you think is causing it. The code base has recently moved to a repository on GitHub<https://github.com/MITgcm/MITgcm> and we’d like to start using the issue tracker there for dealing with bug reports - and discussing how to fix them. One advantage of using the GitHub issue tracker is that you can easily link to bits of code in the issue, and eventually the pull request that implements a fix can also link with the original issue.

If you’re willing to open an issue there, that’d be great.

Cheers,
Ed


________________________________
Edward Doddridge
Postdoctoral researcher
Earth, Atmospheric and Planetary Sciences
Massachusetts Institute of Technology

www.doddridge.me<http://www.doddridge.me>

On 8 May 2018, at 09:50, Naughten, Kaitlin A. <kaight at bas.ac.uk<mailto:kaight at bas.ac.uk>> wrote:

Hello,

I'm writing to report a small bug in the MNC masking option (useMissingValue in data.diagnostics). When I switch this option on, ice shelf diagnostics (SHIfwFlx, SHIhtFlx, SHIuStar) are incorrectly masked. The entire ice shelf is masked out, with only the open ocean (where these variables are zero) unmasked.

In the subroutine diagnostics_mnc_out, it looks like maskC is applied at klev=1, since the ice shelf variables have already been compressed into a 2D array. But in fact this 2D array represents all different values of klev, none of which are 1 beneath the ice shelf.

I'm not sure of the most efficient way to solve this problem, as I'm not very familiar with the code base yet, so I thought I'd report it here before I tried to fix it myself! If someone sees an obvious solution, I'm happy to implement it.

Many thanks,
Kaitlin Naughten
________________________________
This message (and any attachments) is for the recipient only. NERC is subject to the Freedom of Information Act 2000 and the contents of this email and any reply you make may be disclosed by NERC unless it is exempt from release under the Act. Any material supplied to NERC may be stored in an electronic records management system.
________________________________
_______________________________________________
MITgcm-support mailing list
MITgcm-support at mitgcm.org<mailto:MITgcm-support at mitgcm.org>
http://mailman.mitgcm.org/mailman/listinfo/mitgcm-support

________________________________
This message (and any attachments) is for the recipient only. NERC is subject to the Freedom of Information Act 2000 and the contents of this email and any reply you make may be disclosed by NERC unless it is exempt from release under the Act. Any material supplied to NERC may be stored in an electronic records management system.
________________________________
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.mitgcm.org/pipermail/mitgcm-support/attachments/20180509/84581dbd/attachment-0001.html>