<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Thanks very much Ed. I've opened an issue here: <a href="https://github.com/MITgcm/MITgcm/issues/97" class="OWAAutoLink">https://github.com/MITgcm/MITgcm/issues/97</a></p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> MITgcm-support <mitgcm-support-bounces@mitgcm.org> on behalf of Edward W Doddridge <ewd@mit.edu><br>
<b>Sent:</b> 08 May 2018 21:41:39<br>
<b>To:</b> mitgcm-support@mitgcm.org<br>
<b>Subject:</b> Re: [MITgcm-support] Problem with MNC masking of ice shelf diagnostics</font>
<div> </div>
</div>
<meta content="text/html; charset=utf-8">
<div class="" style="word-wrap:break-word; line-break:after-white-space">Hi Kaitlin,
<div class=""><br class="">
</div>
<div class="">Thanks for taking the time to report this, and to track down what you think is causing it. The code base has recently moved to a <a href="https://github.com/MITgcm/MITgcm" class="">repository on GitHub</a> and we’d like to start using the issue
tracker there for dealing with bug reports - and discussing how to fix them. One advantage of using the GitHub issue tracker is that you can easily link to bits of code in the issue, and eventually the pull request that implements a fix can also link with
the original issue.</div>
<div class=""><br class="">
</div>
<div class="">If you’re willing to open an issue there, that’d be great.</div>
<div class=""><br class="">
</div>
<div class="">Cheers,</div>
<div class="">Ed</div>
<div class=""><br class="">
<div class="">
<div class="" style="color:rgb(0,0,0); font-family:Palatino; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:auto; word-spacing:0px">
<span class="x_Apple-style-span" style="line-height:normal; border-collapse:separate; border-spacing:0px"><br class="x_Apple-interchange-newline">
<hr class="" style="font-family:Tahoma; font-size:13px">
<span class="x_Apple-style-span" style="font-family:Tahoma; font-size:13px"><font face="Tahoma" size="2" class=""><span dir="ltr" class="" style="font-size:10pt"><font size="1" class=""><span class="" style="font-size:13px"><font size="2" class=""><b class="">Edward
Doddridge</b><br class="">
<i class="">Postdoctoral researcher</i></font></span></font></span></font></span></span></div>
<div class="" style="color:rgb(0,0,0); font-family:Palatino; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:auto; word-spacing:0px">
<span class="x_Apple-style-span" style="line-height:normal; border-collapse:separate; border-spacing:0px"><span class="x_Apple-style-span" style="font-family:Tahoma; font-size:13px"><font face="Tahoma" size="2" class=""><span dir="ltr" class="" style="font-size:10pt"><font size="1" class=""><span class="" style="font-size:13px"><font size="2" class=""><i class="">Earth,
Atmospheric and Planetary Sciences</i></font></span></font></span></font></span></span></div>
<div class="" style="color:rgb(0,0,0); font-family:Palatino; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:auto; word-spacing:0px">
<span class="x_Apple-style-span" style="line-height:normal; border-collapse:separate; border-spacing:0px"><span class="x_Apple-style-span" style="font-family:Tahoma; font-size:13px"><font face="Tahoma" size="2" class=""><span dir="ltr" class="" style="font-size:10pt"><font size="1" class=""><span class="" style="font-size:13px"><font size="2" class=""><i class="">Massachusetts
Institute of Technology</i></font></span></font></span></font></span></span></div>
<div class="" style="color:rgb(0,0,0); font-family:Palatino; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:auto; word-spacing:0px">
<div class="" style="line-height:normal"><span class="x_Apple-style-span" style="border-collapse:separate; line-height:normal; orphans:2; widows:2; border-spacing:0px"><span class="x_Apple-style-span" style="font-family:Tahoma; font-size:13px"><font face="Tahoma" size="2" class=""><span dir="ltr" class="" style="font-size:10pt"><font size="1" class=""><span class="" style="font-size:13px"><font size="2" class=""><i class=""><br class="">
</i></font></span></font></span></font></span></span></div>
<div class="" style="line-height:normal"><span class="x_Apple-style-span" style="border-collapse:separate; line-height:normal; orphans:2; widows:2; border-spacing:0px"><span class="x_Apple-style-span" style="font-family:Tahoma; font-size:13px"><font face="Tahoma" size="2" class=""><a href="http://www.doddridge.me" class="">www.doddridge.me</a></font></span></span></div>
</div>
</div>
<div><br class="">
<blockquote type="cite" class="">
<div class="">On 8 May 2018, at 09:50, Naughten, Kaitlin A. <<a href="mailto:kaight@bas.ac.uk" class="">kaight@bas.ac.uk</a>> wrote:</div>
<br class="x_Apple-interchange-newline">
<div class="">
<div id="x_divtagdefaultwrapper" dir="ltr" class="" style="font-size:12pt; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; text-decoration:none; font-family:Calibri,Helvetica,sans-serif">
<div class="" style="margin-top:0px; margin-bottom:0px">Hello,</div>
<div class="" style="margin-top:0px; margin-bottom:0px"><br class="">
</div>
<div class="" style="margin-top:0px; margin-bottom:0px">I'm writing to report a small bug in<span class="" style="font-size:12pt"> the MNC masking option (useMissingValue in data.diagnostics). When I switch this option on, ice shelf diagnostics (SHIfwFlx, SHIhtFlx,
SHIuStar) are incorrectly masked. The entire ice shelf is masked out, with only the open ocean (where these variables are zero) unmasked.</span></div>
<div class="" style="margin-top:0px; margin-bottom:0px"><span class="" style="font-size:12pt"><br class="">
</span></div>
<div class="" style="margin-top:0px; margin-bottom:0px"><span class="" style="font-size:12pt">In the subroutine diagnostics_mnc_out, it looks like maskC is applied at klev=1, since the ice shelf variables have already been compressed into a 2D array. But in
fact this 2D array represents all different values of klev, none of which are 1 beneath the ice shelf.</span></div>
<div class="" style="margin-top:0px; margin-bottom:0px"><span class="" style="font-size:12pt"><br class="">
</span></div>
<div class="" style="margin-top:0px; margin-bottom:0px"><span class="" style="font-size:12pt">I'm not sure of the most efficient way to solve this problem, as I'm not very familiar with the code base yet, so I thought I'd report it here before I tried to fix
it myself! If someone sees an obvious solution, I'm happy to implement it.</span></div>
<div class="" style="margin-top:0px; margin-bottom:0px"><span class="" style="font-size:12pt"><br class="">
</span></div>
<div class="" style="margin-top:0px; margin-bottom:0px">Many thanks,</div>
<div class="" style="margin-top:0px; margin-bottom:0px">Kaitlin Naughten</div>
</div>
<hr class="" style="font-family:Palatino-Roman; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; text-decoration:none">
<small class="" style="font-family:Palatino-Roman; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; text-decoration:none">This message (and any attachments)
is for the recipient only. NERC is subject to the Freedom of Information Act 2000 and the contents of this email and any reply you make may be disclosed by NERC unless it is exempt from release under the Act. Any material supplied to NERC may be stored in
an electronic records management system</small><span class="" style="font-family:Palatino-Roman; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; text-decoration:none; float:none; display:inline!important">.</span>
<hr class="" style="font-family:Palatino-Roman; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; text-decoration:none">
<span class="" style="font-family:Palatino-Roman; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; text-decoration:none; float:none; display:inline!important">_______________________________________________</span><br class="" style="font-family:Palatino-Roman; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; text-decoration:none">
<span class="" style="font-family:Palatino-Roman; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; text-decoration:none; float:none; display:inline!important">MITgcm-support
mailing list</span><br class="" style="font-family:Palatino-Roman; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; text-decoration:none">
<a href="mailto:MITgcm-support@mitgcm.org" class="" style="font-family:Palatino-Roman; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:auto; word-spacing:0px">MITgcm-support@mitgcm.org</a><br class="" style="font-family:Palatino-Roman; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; text-align:start; text-indent:0px; text-transform:none; white-space:normal; word-spacing:0px; text-decoration:none">
<a href="http://mailman.mitgcm.org/mailman/listinfo/mitgcm-support" class="" style="font-family:Palatino-Roman; font-size:16px; font-style:normal; font-weight:normal; letter-spacing:normal; orphans:auto; text-align:start; text-indent:0px; text-transform:none; white-space:normal; widows:auto; word-spacing:0px">http://mailman.mitgcm.org/mailman/listinfo/mitgcm-support</a></div>
</blockquote>
</div>
<br class="">
</div>
</div>
<hr>
<small>This message (and any attachments) is for the recipient only. NERC is subject to the Freedom of Information Act 2000 and the contents of this email and any reply you make may be disclosed by NERC unless it is exempt from release under the Act. Any material
supplied to NERC may be stored in an electronic records management system</small>.
<hr>
</body>
</html>