[MITgcm-support] bugs in ctrl pkg?

[Charlotte Breitkreuz]

Dear MITgcm developers,

this concerns only the ctrl pkg. I think there are two things that 
possibly need to be changed in the control pkg - if I'm not wrong. And I 
also have one question.

Consider a configuration where the exf fields atemp, aqh, precip, uwind, 
vwind  are used as control variables and also some 3d generic variables, 
for example initial tracer fields, are additional control variables. 
Therefore it is set #define ALLOW_ATEMP_CONTROL,..., and #define 
ALLOW_GENARR3D_CONTROL, and hence ctrlUseGen = TRUE (see ctrl_readparms.F).

Two problems arise in this setting:

In exf_getffields.F (from line 480) it is:

if (.NOT.ctrlUseGen) then

#ifdef ALLOW_ATEMP_CONTROL
       CALL CTRL_GET_GEN (
      &     xx_atemp_file, xx_atempstartdate, xx_atempperiod, ....

....

endif

and so on. So ctrl_get_gen is never called for these exf fields (atemp, 
aqh, precip. swdown, lwdown) if I use a generic controlvariable at the 
same time. Is this on purpose? Why?


And the second problem is that again in exf_getffields.F (from line 573)

CALL CTRL_GET_GEN (
      &     xx_uwind_file, xx_uwindstartdate, xx_uwindperiod, ....

is called. Then in ctrl_get_gen (from line 115):

       if ( (optimcycle .ge. 0).AND.ctrlUseGen ) then
         ilgen=ilnblnk( xx_gen_file )
         write(fnamegen(1:80),'(2a,i10.10)')
      &    xx_gen_file(1:ilgen),'.effective.',optimcycle
       endif

....

call active_read_xy( fnamegen, ....

....

This will occur as problem at run time, because xx_uwind.effective* was 
never written. The xx_*effective* file is just written for the generic 
control variables in ctrl_map_ini_genarr.F. So this problem again only 
comes up when the exf fields (uwind,vwind,evap,...) are used together 
with ctrlUseGen=TRUE.


And then I have one more question. What is this xx*effective* even for? 
Why not use the normal xx* name as it is done for not-generic control 
variables?


Best wishes,

Charlotte


-- 
*Charlotte Breitkreuz*, M. Sc. Technomathematik
PhD Student
Research Group 'Geosystem Modeling'

*MARUM* - Center for Marine Environmental Sciences, University of Bremen
*FB5* - Department of Geosciences, University of Bremen
Klagenfurter Straße 2
28359 Bremen, Germany
Room 5420

Tel: +49(0)421 - 218 65448

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mitgcm.org/pipermail/mitgcm-support/attachments/20160830/62c3184c/attachment.htm>