[MITgcm-devel] cost_generic.F

[gael forget]

Hi Matt,
you can go ahead. I probably added the “.AND.( localperiod .NE. 86400. )" 
because I was unsure it would work for the daily+cyclic case, which I don’t
think has ever been tested. It would be great if you could check that the 
daily+cyclic case is safe with the proposed modification since it now 
permits this case. Leap years may require an explicit treatment, such as : 
- if localrec>365 then localrec=365 to avoid the model from crashing.
- or a stop+message if the input data file does not have 365 days.
Gael

On Jul 24, 2014, at 2:07 PM, Matthew Mazloff <mmazloff at ucsd.edu> wrote:

> Hello
> 
> I am not a fan of line 236 in cost_generic.F
> 
> If you give a localobsfile that is
> file.bin and has a 86400 day period (e.g. daily SST) it will not be read.
> 
> One must put 
> file.bin_2010
> 
> Can we change this to from:
> 
> 236	        if ( (.NOT. exst).AND.( localperiod .NE. 86400. ) ) then
> 237	           write(fname2(1:128),'(a)') localobsfile(1:il)
> 238	           inquire( file=fname2, exist=exst )
> 239	#ifndef COST_GENERIC_ASSUME_CYCLIC
> 240	c assume we have one big file, one year after the other
> 241	           localrec = obsrec
> 242	c otherwise assume climatology, used for each year
> 243	#endif
> 244	        endif
> 
> to
> 
> 236	        if  (.NOT. exst)  then
> 
> If so, what else has to be put in to make 
> #define COST_GENERIC_ASSUME_CYCLIC
> safe?
> 
> Thanks
> Matt
> 
> 
> 
> 
> 
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1578 bytes
Desc: not available
URL: <http://mitgcm.org/pipermail/mitgcm-devel/attachments/20140728/fbd9266f/attachment.p7s>