[MITgcm-devel] Fwd: [MITgcm-cvs] MITgcm/pkg/seaice CVS Commit

[Martin Losch]

Thanks,

Martin
On Jul 11, 2014, at 7:03 PM, Jean-Michel Campin <jmc at ocean.mit.edu> wrote:

> Hi Martin,
> 
> I took a look at your changes, and seems good to me.
> I have also a stupid test (where the solution is expected to be
> the free-drift) and it gives same results as before, with LSR_mixIniGuess=1
> or LSR_mixIniGuess=2.
> 
> Cheers,
> Jean-Michel
> 
> On Fri, Jul 11, 2014 at 11:40:40AM +0200, Martin Losch wrote:
>> Hi Jean-Michel (and others),
>> 
>> the freedrift code changes mean that residuals are computed in different orders. None of the forward ad AD results changed (at least not on my machine, I didn’t test TLM), but unintentionally I may have modified the logic behind the free drift code (and it just does not show up in the tests). If you could check the convoluted if-statements for consistency, I’d be greatful.
>> 
>> Martin
>> 
>> 
>> Begin forwarded message:
>> 
>>> From: Martin Losch <mlosch at forge.csail.mit.edu>
>>> Subject: [MITgcm-cvs] MITgcm/pkg/seaice CVS Commit
>>> Date: July 11, 2014 at 11:37:35 AM GMT+2
>>> To: <mitgcm-cvs at mitgcm.org>
>>> Reply-To: <MITgcm-cvs at mitgcm.org>
>>> 
>>> Update of /u/gcmpack/MITgcm/pkg/seaice
>>> In directory forge:/tmp/cvs-serv21204/pkg/seaice
>>> 
>>> Modified Files:
>>> 	seaice_lsr.F 
>>> Log Message:
>>> a little bit of clean up
>>> - rearrange some code blocks, so that now all calculations for
>>>   setting up the right-hand-sides done within one single block 
>>>   (I find that easier to read and understand)
>>> - rearrange freedrift-code to reduce the number of ifdefs
>>> - adjust some indentations and comments
>>> 
>>> 
>>> _______________________________________________
>>> MITgcm-cvs mailing list
>>> MITgcm-cvs at mitgcm.org
>>> http://mitgcm.org/mailman/listinfo/mitgcm-cvs
>> 
>> 
>> _______________________________________________
>> MITgcm-devel mailing list
>> MITgcm-devel at mitgcm.org
>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
> 
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel