[MITgcm-devel] simpler/shorter main_do_loop.F

[Patrick Heimbach]

Hi Jean-Michel,

On Aug 3, 2013, at 12:25 PM, Jean-Michel Campin <jmc at ocean.mit.edu> wrote:

> Hi Patrick,
> 
> I am going to remove the STORE_LOADEDREC_TEST stuff in model/src/main_do_loop.F
> (since it's wrong). 

I can't remember, but don't think I put it there (but might be wrong).
Perhaps some user called jmc ;)
http://mitgcm.org/viewvc/MITgcm/MITgcm/model/src/the_main_loop.F?r1=1.115&r2=1.116&sortby=date&

> I was also tempted to remove all the 1rst part of  
> the (long) list of included header files within:
>> #ifdef ALLOW_AUTODIFF
>> # ifndef ALLOW_AUTODIFF_OPENAD
> and just keeping the 2nd part (also used with ALLOW_AUTODIFF_OPENAD).
> 
> I think this would make things more clear that this routine
> really matter for OpenAD (and not much, just a call to FORWARD_STEP,
> otherwise). One might even think of placing the 2nd part of the
> included header list within #ifdef ALLOW_AUTODIFF_OPENAD.
> 
> I did run all the AD (taf) test, and nothing change (same taf_ad.log).
> 
> What is your view on this ?

I can check, but happy to follow your suggestions since the tests are fine.
Basically, if I remember correct, this was a start to unify required includes
between OpenAD and TAF (but not cleaned).

Cheers
p.

> Cheers,
> Jean-Michel
> 
> 
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel


---
Patrick Heimbach | heimbach at mit.edu | http://www.mit.edu/~heimbach
MIT | EAPS 54-1420 | 77 Massachusetts Ave | Cambridge MA 02139 USA
FON +1-617-253-5259 | FAX +1-617-253-4464 | SKYPE patrick.heimbach

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1588 bytes
Desc: not available
URL: <http://mitgcm.org/pipermail/mitgcm-devel/attachments/20130803/99234093/attachment.p7s>