[MITgcm-devel] simpler/shorter main_do_loop.F

Jean-Michel Campin jmc at ocean.mit.edu
Sat Aug 3 12:25:58 EDT 2013


Hi Patrick,

I am going to remove the STORE_LOADEDREC_TEST stuff in model/src/main_do_loop.F
(since it's wrong). 
I was also tempted to remove all the 1rst part of  
the (long) list of included header files within:
> #ifdef ALLOW_AUTODIFF
> # ifndef ALLOW_AUTODIFF_OPENAD
and just keeping the 2nd part (also used with ALLOW_AUTODIFF_OPENAD).

I think this would make things more clear that this routine
really matter for OpenAD (and not much, just a call to FORWARD_STEP,
otherwise). One might even think of placing the 2nd part of the
included header list within #ifdef ALLOW_AUTODIFF_OPENAD.

I did run all the AD (taf) test, and nothing change (same taf_ad.log).

What is your view on this ?

Cheers,
Jean-Michel




More information about the MITgcm-devel mailing list