[MITgcm-devel] [MITgcm-cvs] MITgcm/model/src CVS Commit

[Jean-Michel Campin]

Hi Patrick,

I think that in monitor.F, nothing happen when the corresponding 
freq is zero, because DIFFERENT_MULTIPLE is false.
The thing that I was not aware of is the ADSEAICE_MONITOR &
ADPTRACERS_MONITOR are called outside the DIFFERENT_MULTIPLE
block in monitor_ad.F, but both of them are using also adjmonitorFreq,
so should not be a problem.

The idea to test for monitorFreq & adjMonitorFreq  > 0 is to 
mimic a "IF ( useMonitor ) " (except there is no useMonitor).

I also looked to the cvs history of forward_step.F, and it appears
that I broke the ad_monitor call when I (naively) replaced the 
"IF ( .NOT.useOffLine )" with "IF ( monitorFreq.GT.0. )"
(I was testing my changes with tutorial_dic_adjoffline, but the
the problem did not show up there).
 
Cheers,
Jean-Michel

On Fri, Jan 06, 2012 at 11:46:31AM -0500, Patrick Heimbach wrote:
> 
> Thanks, your suggestion makes more sense, but one caveat:
> It might be that the recomputations will also (re-)do forward monitor output.
> What I wanted to do is that after S/R turnoff_model_io
> monitor output is produce *only* when we are really in AD-mode
> (i.e. skipping all recomputations).
> Don't think that it's captured by your suggestion.
> 
> -p.
> 
> On Jan 6, 2012, at 11:39 AM, Jean-Michel Campin wrote:
> 
> > Patrick,
> > 
> > I will do that soon.
> > Cheers,
> > Jean-Michel
> > 
> > On Fri, Jan 06, 2012 at 11:35:30AM -0500, Patrick Heimbach wrote:
> >> Hi Jean-Michel,
> >> fine with me.
> >> Am going to be offline now,
> >> so perhaps you could change?
> >> p.
> >> 
> >> On Jan 6, 2012, at 11:24 AM, Jean-Michel Campin wrote:
> >> 
> >>> Patrick,
> >>> 
> >>> I have a suggestion, to use:
> >>>   IF ( monitorFreq.GT.0. .OR. adjMonitorFreq.GT.0. ) THEN
> >>> instead of:
> >>>   IF ( monitorFreq.GT.0. .OR. inAdmode .EQV. inAdTrue ) THEN
> >>> This would be just the extension of the previous 
> >>>   IF ( monitorFreq.GT.0. ) THEN 
> >>> What do you think ?
> >>> 
> >>> Cheers,
> >>> Jean-Michel
> >>> 
> >>> On Fri, Jan 06, 2012 at 11:06:41AM -0500, Jean-Michel Campin wrote:
> >>>> Hi Patrick,
> >>>> 
> >>>> I don't think that this modification is doing what you expect:
> >>>> I don't get any monitor from forward_step anymore 
> >>>> in all forward exp. (only the initial one, when S/R MONITOR
> >>>> is called from initialise_varia.F).
> >>>> This is anoying and will need to be fixed soon.
> >>>> 
> >>>> Cheers,
> >>>> Jean-Michel
> >>>> 
> >>>> On Fri, Jan 06, 2012 at 05:58:29AM -0500, Patrick Heimbach wrote:
> >>>>> Update of /u/gcmpack/MITgcm/model/src
> >>>>> In directory forge:/tmp/cvs-serv20244
> >>>>> 
> >>>>> Modified Files:
> >>>>> 	forward_step.F 
> >>>>> Log Message:
> >>>>> Extend cases under which MONITOR is called
> >>>>> (monitorFreq is reset to zero in S/R turnoff_model_io)
> >>>>> 
> >>>>> 
> >>>>> _______________________________________________
> >>>>> MITgcm-cvs mailing list
> >>>>> MITgcm-cvs at mitgcm.org
> >>>>> http://mitgcm.org/mailman/listinfo/mitgcm-cvs
> >>>> 
> >>>> _______________________________________________
> >>>> MITgcm-devel mailing list
> >>>> MITgcm-devel at mitgcm.org
> >>>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
> >>> 
> >>> _______________________________________________
> >>> MITgcm-devel mailing list
> >>> MITgcm-devel at mitgcm.org
> >>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
> >> 
> >> ---
> >> Patrick Heimbach | heimbach at mit.edu | http://www.mit.edu/~heimbach
> >> MIT | EAPS 54-1420 | 77 Massachusetts Ave | Cambridge MA 02139 USA
> >> FON +1-617-253-5259 | FAX +1-617-253-4464 | SKYPE patrick.heimbach
> >> 
> >> 
> >> 
> >> _______________________________________________
> >> MITgcm-devel mailing list
> >> MITgcm-devel at mitgcm.org
> >> http://mitgcm.org/mailman/listinfo/mitgcm-devel
> > 
> > _______________________________________________
> > MITgcm-devel mailing list
> > MITgcm-devel at mitgcm.org
> > http://mitgcm.org/mailman/listinfo/mitgcm-devel
> 
> ---
> Patrick Heimbach | heimbach at mit.edu | http://www.mit.edu/~heimbach
> MIT | EAPS 54-1420 | 77 Massachusetts Ave | Cambridge MA 02139 USA
> FON +1-617-253-5259 | FAX +1-617-253-4464 | SKYPE patrick.heimbach
> 
> 
> 
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel