[MITgcm-devel] sea ice clean up this week

[Gael Forget]

Martin,
> Sorry for being to fast with my email. Now I see where the feature went: into SEAICE_availHeatFracFrz. 
no worries. I was waiting for test report to confirm we are in the clear before posting 
an explanation on MITgcm devel. I will do later, but you already figured it out.
> Maybe a question for Ian: Will this formulation make a difference for the adjoint?
Assuming that 1D_ocean_ice_column is suited to detect relevant adjoint changes,
there was none beyond truncation level in fwd or ad mode. So I feel relatively
confident about that, altough the fact that 1D_ocean_ice_column apparently 
never had very close gradient checks worries me a little.

Gael

> The remainder of my previous email is still valid (I think).
> 
> M.
> 
> On Feb 8, 2012, at 4:23 PM, Martin Losch wrote:
> 
>> Hi Gael,
>> 
>> I think that during last nights check-ins you accidentally removed the "feature" of the MCPHEE_OCEAN_ICE_HEAT_FLUX, that the ocean can only melt. 
>> Please put that back in, possibly as yet another option.
>> 
>> Also, sorry to be such a nuisance about vector performance: If possible, divisions in loops should be avoided, so could you/can we replace
>> - (MCPHEE_TAPER_FAC-1)/MCPHEE_TAPER_FAC with something that is precomputed (at the beginning of the routine
>> - /QI with *recipQI (to be defined)
>> - /ndim with *recip_nDim (to be defined)
>> - /ICE2SNOW with SNOW2ICE (to be defined)
>> - /rhoConst with recip_rhoConst
>> - /SEAICE_deltaTherm with recip_deltaTtherm or so (to be defined)
>> - /0.0001 _d 0 with 1. _d 4 (and maybe a comment where this comes from)
>> ? Most of this was there before last nights check-ins. Some of these changes will change the results (i.e. the ICE2SNOW part in the legacy code did so in the past), but since you have changed the reference results at truncation level anyway, it probably does not matter. I'd be happy if you could incorporate these changes into your clean-up sweep (and not introduce more unnecessary), but if you don't want to I can do it, too.
>> 
>> Martin
>> 
>> 
>> On Feb 6, 2012, at 10:39 PM, Gael Forget wrote:
>> 
>>> Dear all,
>>> just a quick email to let you know that I will proceed
>>> with the needed seaice clean up in the next few days.
>>> I will wait until tomorrow to do the first part, to avoid 
>>> interfering with the test  of Jean-Michel's commit tonight.
>>> Along the same line, I would appreciate it if you could 
>>> restrain for committing further changes to pkg/seaice 
>>> for a few days. It would make my life much easier.
>>> Thanks in advance,
>>> Gael
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
>>> _______________________________________________
>>> MITgcm-devel mailing list
>>> MITgcm-devel at mitgcm.org
>>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>> 
>> 
>> _______________________________________________
>> MITgcm-devel mailing list
>> MITgcm-devel at mitgcm.org
>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
> 
> 
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel