[MITgcm-devel] [MITgcm-cvs] MITgcm/pkg/seaice CVS Commit

[Gael Forget]

Hi dimitris,
that CPP is only retired since you retired it. It was setting the
SEAICE_multDim default, which was all that was needed
to preserve the previous behavior of pkg/seaice. Since you 
effectively changed the default of SEAICE_multDim, any user 
of SEAICE_MULTICATEGORY will have to change his namelist,
otherwise his results will change. Just like what Jean Michel 
did to fix the verification experiment. Except those users may 
not notice the warning, and thus end up with different results. 
So a stop may be needed, to avoid tricking users. This is 
what I was trying to avoid with the code you removed. 
Cheers,
Gael 



On Dec 21, 2012, at 10:22 AM, Dimitris Menemenlis wrote:

> Jean-Michel, my preference would be not to leave retired CPP options in the verification experiments.  It's confusing when you have not followed CVS check ins for a while and then try to update an experiment.  It's also confusing for MITgcm users who rely on verification experiments as initial templates for their work.
> 
> If you agree with above, I can remove remaining SEAICE_MULTICATEGORY from the verification experiments later today.  I promise to be more careful and to run the full suite of experiments before check in.
> 
> If you prefer to leave as is and change "Error+Stop" into a "Warning", that's fine too.  Let me know.
> 
> Dimitris Menemenlis
> 
> On 12/21/2012 06:50 AM, Jean-Michel Campin wrote:
>> Hi Dimitris,
>> 
>> From this cvs-commit message, I thought it was a just warning.
>> But when I look to the code (and check the experiments that are
>> now failing), it's an Error + Stop.
>> 
>> So, here is my question:
>> - should we transform this Error+Stop into a warning ?
>> or
>> - should we keep this Error+Stop and make the necessary changes to
>> the few broken experiments (there is also the baltic experiment test
>> run by Oliver on beagle, e.g.:
>> http://mitgcm.org/testing/results/2012_12/tr_beagle-ifort_20121221_2/summary.txt
>> which are affected) ?
>> 
>> Cheers,
>> Jean-Michel
> 
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel