[MITgcm-devel] [MITgcm-cvs] MITgcm/pkg/seaice CVS Commit

[Dimitris Menemenlis]

OK.  I will proceed as per instructions below (change to warning and 
clean up only the "almost" up-to-date experiments that you list below). 
  And hopefully I don't break more things along the way ...

Dimitris Menemenlis

On 12/21/2012 08:41 AM, Jean-Michel Campin wrote:
> Hi Dimitris,
>
> My impression is that having a warning instead of error+stop
> is a good compromise (and also match the check-in msg description:-)  ):
> if, a user, in the process of updating his code,
> leaves #define SEAICE_MULTICATEGORY in SEAICE_OPTIONS.h,
> which does not do anything anymore, since it has been removed from the code,
> there will be a clear warning message - but it offers the advantage of
> not beeing force to update it at the same time, and use the same
> customized code dir for the new and old version).
> But it's just my personal impression.
> That beeing said, in seaice_check.F, we find both type
> of messages for retired CPP options (SEAICE_EXTERNAL_FORCING
> gives an error but does not stop - would be better to have a
> warning there - and SEAICE_ALLOW_TD_IF gives an error and stops).
>
> Updating SEAICE_OPTIONS.h :
> 1) should definitively update pkg/seaice/SEAICE_OPTIONS.h
> 2) can be tricky to update all verification/*/code*/SEAICE_OPTIONS.h
>   since some have not been updated for a long time, and, in addition,
>   there is SEAICE_GROWTH_LEGACY that will be removed soon.
>   So, I would prefer to see only the "almost" up-to-date beeing updated
>   now (as you did previously):
>     1D_ocean_ice_column/code/SEAICE_OPTIONS.h
>     offline_exf_seaice/code/SEAICE_OPTIONS.h
>     seaice_obcs/code/SEAICE_OPTIONS.h
>   and postpone the update of the others until SEAICE_GROWTH_LEGACY is gone.
>
> Cheers,
> Jean-Michel