[MITgcm-devel] once again: ctrl + obcs

[Martin Losch]

Dear ctrl-ers,

I just noticed the CPP flag CTRL_PACK_PRECISE in ctrl_set_pack/unpack_xyz.F, which controls the weighting for "ALLOW_NONDIMENSIONAL_CONTROL_IO".
Interestingly this flag is also used in ctrl_set_pack_yz/xz.F but not in ctrl_set_unpack_yz/xz.F, there it is called CTRL_UNPACK_PRECISE. It looks like someone has just used copy and paste to create the latter files an replaced all "pack" with "unpack". I do not think that this will work and suggest removing everything related to this flag in the obcs-related routines (_yz/xz).

Further, there is a flag "NO_CONTROL_BAROTROPIC_VELOCITY" that I overlooked earlier when I got rid of the now obsolete splitting of baroclinic and barotropic control of obcs. I suggest to remove that also.

Opinions?

Martin