[MITgcm-devel] (not so) funny things happen in seaice_lsr and pickups

[Martin Losch]

Hi Jean-Michel,

I'll create a SEAICE_GRID.h, there are actually quite a few fields in  
SEAICE.h, that are really grid parameters (e.g., masks). These are  
then initialized in seaice_init_varia.F which is not quite consistent  
either. I'll do something about that once the C-LSR with metric terms  
proves to be stable (it's still running, but I need at least the  
weekend before I can say more)

Martin

On Mar 5, 2009, at 10:44 PM, Jean-Michel Campin wrote:

> Hi Martin,
>
> I guess it depends if we want
> tanPhiAtZ and tanPhiAtC arrays to always be defined
> (in this case, they will sit in GRID.h) or if we want
> to define those 2 2-D arrays only with pkg/seaice,
> and in this case I will prefer to put them elsewhere,
> so that when GRID.h is included without PACKAGES_CONFIG.h
> we don't have an incomplete file. Why not keeping those
> 2 simple names tanPhiAtZ/C, but in a new header file
> SEAICE_GRID.h ?  This way, if, in the future, they need
> to be move back to GRID.h, it will not be a big deal.
> And they could be set in ini_spherical_polar_grid.F
> before the grid-rotation.
>
> Just a comment: regarding the the grid-rotation calls, them
> could have been put in ini_grid.F (and then used also with
> curvilinear grids, when x & y are lon & lat), no ?
>
> Jean-Michel
>
> On Thu, Mar 05, 2009 at 12:16:31PM -0800, Dimitris Menemenlis wrote:
>> I will let JM answer this.
>>
>> On Mar 5, 2009, at 11:17 AM, Martin Losch wrote:
>>
>>> However, first I'd like to get a comment on how to add these new
>>> fields tanPhiAtZ and tanPhiAtC (see a previous email in this  
>>> thread).
>>> Currently I have implemented a version that is "private" to
>>> pkg/seaice, because these fields would not be used elsewhere. Or  
>>> is it
>>> better to define these fields in GRID.h where they would actually
>>> belong?
>>
>> _______________________________________________
>> MITgcm-devel mailing list
>> MITgcm-devel at mitgcm.org
>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel