[MITgcm-devel] (not so) funny things happen in seaice_lsr and pickups
Jean-Michel Campin
jmc at ocean.mit.edu
Thu Mar 5 16:44:24 EST 2009
Hi Martin,
I guess it depends if we want
tanPhiAtZ and tanPhiAtC arrays to always be defined
(in this case, they will sit in GRID.h) or if we want
to define those 2 2-D arrays only with pkg/seaice,
and in this case I will prefer to put them elsewhere,
so that when GRID.h is included without PACKAGES_CONFIG.h
we don't have an incomplete file. Why not keeping those
2 simple names tanPhiAtZ/C, but in a new header file
SEAICE_GRID.h ? This way, if, in the future, they need
to be move back to GRID.h, it will not be a big deal.
And they could be set in ini_spherical_polar_grid.F
before the grid-rotation.
Just a comment: regarding the the grid-rotation calls, them
could have been put in ini_grid.F (and then used also with
curvilinear grids, when x & y are lon & lat), no ?
Jean-Michel
On Thu, Mar 05, 2009 at 12:16:31PM -0800, Dimitris Menemenlis wrote:
> I will let JM answer this.
>
> On Mar 5, 2009, at 11:17 AM, Martin Losch wrote:
>
>> However, first I'd like to get a comment on how to add these new
>> fields tanPhiAtZ and tanPhiAtC (see a previous email in this thread).
>> Currently I have implemented a version that is "private" to
>> pkg/seaice, because these fields would not be used elsewhere. Or is it
>> better to define these fields in GRID.h where they would actually
>> belong?
>
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel
More information about the MITgcm-devel
mailing list