[MITgcm-devel] Re: [MITgcm-cvs] MITgcm/model/src CVS Commit

[chris hill]

Salut David,

  Steph is the GCHEM, DIC boss and can pronounce the final verdict on 
what should be done where and why. We should have an exciting meeting 
about this when Steph gets back - if you are lucky you will be back by 
then too.

Chris
David Ferreira wrote:
> Hi Martin,
> I was actually struggling a bit with the "russian doll"
> packages. At the beginning, I put the call to dic_write_pickup
> inside the ALLOW_PTRACER, inside ALLOW_GCHEM, inside
> ALLOW_DIC.
> The aesthetic of it clearly told me it was the wrong solution.
> 
> I don't mind adding a level (i.e. gchem_write_pickup) which would
> deal with the details of the tracers used. It would be cleaner,
> I agree, but is it really worth for just one case ? (pH in dic and
> what else ?)
> 
> JMC, Chris, I guess it is your call. I don't mind whichever way.
> david
> 
> 
> 
> Quoting Martin.Losch at awi.de:
> 
>> David,
>>
>> wouldn't it be better to have a gchem_write_pickup?
>> now you start mixing the package levels (packages_* calls gchem_*
>> which calls dic_*).
>> I actually did the same thing as you did (call a
>> recom_write/read_pickup and call it from packages_*), but it's
>> problably not a good idea to do that. I would much rather have
>> gchem_write_pickup.F which will be interface for bgc packages, as it
>> is done for other parts of gchem.
>>
>> Martin
>>
>>
>> Martin Losch
>> Alfred Wegener Institute
>> Postfach 120161, 27515 Bremerhaven, Germany;
>> Tel./Fax: ++49(0471)4831-1872/1797
>>
>>
>>
>> ----- Original Message -----
>> From: David Ferreira <dfer at mitgcm.org>
>> Date: Tuesday, March 11, 2008 9:57 pm
>> Subject: [MITgcm-cvs] MITgcm/model/src CVS Commit
>>
>>> Update of /u/gcmpack/MITgcm/model/src
>>> In directory forge:/tmp/cvs-serv13299
>>>
>>> Modified Files:
>>> 	packages_write_pickup.F
>>> Log Message:
>>> Pieces of code for pickup file for pH in dic (to fix the restart
>>> problem).Not yet active as not backward compatible.
>>>
>>> _______________________________________________
>>> MITgcm-cvs mailing list
>>> MITgcm-cvs at mitgcm.org
>>> http://mitgcm.org/mailman/listinfo/mitgcm-cvs
>>>
>> _______________________________________________
>> MITgcm-devel mailing list
>> MITgcm-devel at mitgcm.org
>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>>
> 
> 
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>