[MITgcm-devel] Re: [MITgcm-cvs] MITgcm/pkg/diagnostics CVS Commit

[Ed Hill]

On Wed, 2005-07-06 at 09:29 -0400, Jean-Michel Campin wrote:
> Hello Ed,
> 
> On Tue, Jul 05, 2005 at 10:13:52PM -0400, Ed Hill wrote:
> > Update of /u/gcmpack/MITgcm/pkg/diagnostics
> > In directory forge:/tmp/cvs-serv9176/pkg/diagnostics
> > 
> > Modified Files:
> > 	diagnostics_readparms.F diagnostics_write.F diagstats_output.F 
> 
> It's just a detail, but it helps to clarify what has been modified
> in the code, when only modified files are checked-in
> (on the cvs webb, diagnostics_readparms.F, diff between version
> 1.13 and 1.12: - No changes -).


Hi Jean-Michel,

With CVS, its basically impossible to check in a change thats a zero-
diff.  It just doesn't work.  So, what you're complaining about is a
failure of the ViewCVS program to correctly parse and display the
difference.

So heres a CVS lesson.  Run the following:

  cd MITgcm/pkg/diagnostics
  cvs diff -u -r 1.13 -r 1.14 diagnostics_readparms.F

and you'll see the minor yet entirely reasonable readability change that
I made to that file.


> Also, I am little bit concerned about this line 39 in "diagstats_output.F"
>  39 edhill 1.3       INTEGER listId, myIter, myTime, myThid
> and would be nice also to document the new S/R argument (like the other 
> arguments).
>  35            C     !INPUT PARAMETERS:
>  36            C     listId :: Diagnostics list number being written
>  37            C     myIter  :: current iteration number
>  38            C     myThid  :: my Thread Id number

OK, I just added the comment.

And, in future, please don't cc: my email address on any lists that I'm
already subscribed to such as MITgcm-devel.  I'm already handling all of
the spam for these lists (that is, I get all the spam and sort through
them so that *you* don't have to) and duplicate emails is just plain
annoying.

Ed

-- 
Edward H. Hill III, PhD
office:  MIT Dept. of EAPS;  Rm 54-1424;  77 Massachusetts Ave.
             Cambridge, MA 02139-4307
emails:  eh3 at mit.edu                ed at eh3.com
URLs:    http://web.mit.edu/eh3/    http://eh3.com/
phone:   617-253-0098
fax:     617-253-4464