[MITgcm-devel] SHORTWAVE_HEATING & KPP

[Jean-Michel Campin]

Hi Dimitri,

I need to use and do little changes related to the 
short-wave heating (Qsw).
It looks like it's now independent of KPP, and added
in external_forcing, which is perfect for me.

But do we really need to always use SHORTWAVE_HEATING
when using KPP ?

in pkg/kpp/kpp_check.F :
> C     Shortwave heating should be defined with KPP
> #ifndef SHORTWAVE_HEATING
>      WRITE(msgBuf,'(A)') 'KPP needs CPP flag SHORTWAVE_HEATING enabled'
>      CALL PRINT_ERROR( msgBuf , 1)
>      STOP 'ABNORMAL END: S/R KPP_CHECK'
>#endif /* SHORTWAVE_HEATING */

Or is it something left from before the separation of
KPP & short-wave heating ?

In fact, for some testing (I am thinking of Benjamin's tests), 
it could be nice to use KPP & SHORTWAVE_HEATING independently.

There is also an annoying thing with the new way to 
turn on and off a pkg (packages.conf & PACKAGES_CONFIG.h), 
because of:
> #ifdef ALLOW_KPP
> #define  SHORTWAVE_HEATING
> #endif
in the default CPP_OPTIONS.h (in model/inc)

And if we know that KPP and SHORTWAVE_HEATING are
really independent, this would allow us to change and 
fix this little problem.

Thanks,

Cheers,

Jean-Michel