[MITgcm-devel] ALLOW_ and PACKAGES_CONFIG.h

[Ed Hill]

On Sun, 2004-03-14 at 16:49, Chris Hill wrote:
> Ed/Alistiar,
> 
>  I was looking at global_ocean.cs32x15.
>  I did a check on the number of .F files that have "ifdef ALLOW..." versus
> the number of .F files that reference "PACKAGES_CONFIG.h". 
>  There are 147 files with "ifdef ALLOW..." and 59 files with
> "PACKAGES_CONFIG.h" in them. 
> 
>  Is this what it should be? That means I can't just put a random #ifdef
> ALLOW_FOO in some routine and have its status from genmake carried through
> by an  "PACKAGES_CONFIG.h" type mechanism. Is that what you intended? Is
> this because you were trying to avoid triggering remakes of everything
> whenever genmake is run? Right now PACKAGES_CONFIG.h seems to be somewhat
> randomly scattered through the code and in some package header files (some
> of which are only include when an option in PACKAGES_CONFIG.h is set!!).
> 
> Chris
> 
> P.S. it only took me three days to figure out that the lack of
> "PACKAGES_CONFIG" in files is why the general CS (ALLOW_EXCH2) exchanges
> don't give the same numbers any more when you change tile sizes :-).


Hi Chris,

Yes, the original idea was to reduce the number of recompiled files. 
But in retrospect, its perhaps not the most useful goal -- compile times
are pretty short on new machines and sometimes its a good idea to do a
fresh compile just to flush out stale stuff.

I also forgot to include PACKAGES_CONFIG.h at least once while testing
the MNC stuff.  Its easy to overlook.

It would be good if we could collectively decide which files should (or
shouldn't) include certain headers and then audit the code for all
headers and CPP options.

Ed

-- 
Edward H. Hill III, PhD
office:  MIT Dept. of EAPS;  Room 54-1424;  77 Massachusetts Ave.
            Cambridge, MA 02139-4307
email:   eh3 at mit.edu,  ed at eh3.com
URL:     http://web.mit.edu/eh3/
phone:   617-253-0098
fax:     617-253-4464
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://mitgcm.org/pipermail/mitgcm-devel/attachments/20040314/04f37057/attachment.sig>