[MITgcm-devel] cd_code done

[Patrick Heimbach]

Hi Ed,

Ed Hill wrote:
> 
> Hi Patrick,
> 
> Sorry for the missing "t" in the file "cd_code_ini_vars.F" versus the
> subroutine CD_CODE_INIT_VARS().  I'll try not to make that mistake
> again.

As I said, it's not a big deal, but a bit anoying
since some bits of the AD-related stuff refer to the file name,
others to the actual S/R name.
So if we can avoid this mismatch, all the better.

> The checkpoint-ing problem is something that JMC, AJA, and I talked
> about yesterday and it looks like it needs to be cleaned up for R2. 
> Basically, the way its currently done appears to be bad because:
>
...

I did a quick fix since I need to separate the initialisation
of the arrays from the read of pickups, again because of AD.
The fix seems cleaner to me, and can be further modified once
the issues you mentioned are clarified.

> 
> So unless I'm mistaken, the order of PACKAGES_INIT_VARIABLES() and
> INI_FIELDS() in INITIALISE_VARIA() should be swapped.  The
> "ideal_2D_oce" test is a perfect example of this because it uses CD_CODE
> and does a pickup.

I've ran the testreport for ideal_2D_oce
It fails in the same way as the testreport you sent this morning,
but it passes if I add just one compiler option: '-ffloat-store'
So my fixes look OK.

Cheers
-p.


> If you think it'd be helpful (or if you think I'm wrong!), we could get
> together this afternoon or tomorrow
> 
> Ed
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://dev.mitgcm.org/mailman/listinfo/mitgcm-devel


-- 
Patrick Heimbach ........................... M.I.T
FON: +1/617/253-5259 .......... EAPS, Room 54-1518
FAX: +1/617/253-4464 ..... 77 Massachusetts Avenue
mailto:heimbach at mit.edu ....... Cambridge MA 02139
http://www.mit.edu/~heimbach/ .............. U.S.A