[MITgcm-devel] cd_code done

[Ed Hill]

On Thu, 2003-10-30 at 11:02, Patrick Heimbach wrote:
> Also,
> the checkpointing I/O part of the CD scheme needs
> to be separated from the init. part into a S/R cd_code_checkpoint
> I'll do that as well.
> -p.


Hi Patrick,

Sorry for the missing "t" in the file "cd_code_ini_vars.F" versus the
subroutine CD_CODE_INIT_VARS().  I'll try not to make that mistake
again.

The checkpoint-ing problem is something that JMC, AJA, and I talked
about yesterday and it looks like it needs to be cleaned up for R2. 
Basically, the way its currently done appears to be bad because:

  1) all the packages seem to do it somewhat differently

  2) variable initialization (setting everything to 0.0 including 
     the "halos") looks like it ought to be done by subroutine 
     calls in READ_CHECKPOINT() but then if you look in 
     INITIALISE_VARIA() you'll notice that the call to 
     PACKAGES_INIT_VARIABLES() happens *after* the call to 
     READ_CHECKPOINT() which means you'd be overwriting the 
     values you just read in--unless you do a *second* check to 
     make sure that you aren't pulling in a checkpoint.  And 
     then how are you supposed to write zeros to the "halo" 
     area?

So unless I'm mistaken, the order of PACKAGES_INIT_VARIABLES() and
INI_FIELDS() in INITIALISE_VARIA() should be swapped.  The
"ideal_2D_oce" test is a perfect example of this because it uses CD_CODE
and does a pickup.

If you think it'd be helpful (or if you think I'm wrong!), we could get
together this afternoon or tomorrow.

Ed

-- 
Edward H. Hill III, PhD
office:  MIT Dept. of EAPS;  Room 54-1424;  77 Massachusetts Ave.
            Cambridge, MA 02139-4307
email:   eh3 at mit.edu,  ed at eh3.com
URL:     http://web.mit.edu/eh3/
phone:   617-253-0098
fax:     617-253-4464
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://mitgcm.org/pipermail/mitgcm-devel/attachments/20031030/deeef307/attachment.sig>