<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Dear Hannah,<div class=""><br class=""></div><div class="">Thanks for spotting these <span style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);" class="">- </span>I think you are correct on both counts. Do you want to submit an issue on GitHub and then either you or I can follow it up with a pull request with corrections?</div><div class=""><br class=""></div><div class="">Thanks,</div><div class=""><br class=""></div><div class="">Jonathan</div><div class=""><div class=""><div class="">
<div style="color: rgb(0, 0, 0); letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant-ligatures: normal; font-variant-position: normal; font-variant-caps: normal; font-variant-numeric: normal; font-variant-alternates: normal; font-variant-east-asian: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div class="">___________________________________________________________________________<br class="">Dr. Jonathan M. Lauderdale<br class="">Research Scientist<br class="">Department of Earth, Atmosphere and Planetary Sciences <br class="">Massachusetts Institute of Technology <br class="">77 Massachusetts Avenue (54-1518)<br class="">Cambridge, MA 02139, USA <br class="">Office: +1 617 324 1568 </div><div class="">Cell : +1 617 304 5661<br class="">Email:<span class="Apple-converted-space"> </span><a href="mailto:jml1@mit.edu" class="">mailto:jml1@mit.edu</a></div><div class=""><span style="text-align: -webkit-auto;" class="">Web: </span><span class=""></span><a href="http://paocweb.mit.edu/people/jml1" style="text-align: -webkit-auto;" class="">http://paocweb.mit.edu/people/jml1</a></div><span class=""><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant-ligatures: normal; font-variant-position: normal; font-variant-caps: normal; font-variant-numeric: normal; font-variant-alternates: normal; font-variant-east-asian: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><span class="">Twitter: </span><a href="https://twitter.com/jon_lauderdale" style="text-align: -webkit-auto;" class="">https://twitter.com/jon_lauderdale<br class=""></a><span style="text-align: -webkit-auto;" class="">Blog: </span><a href="https://seamanticscience.wordpress.com/" style="text-align: -webkit-auto;" class="">https://seamanticscience.wordpress.com/</a></div></span></div><div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant-ligatures: normal; font-variant-position: normal; font-variant-caps: normal; font-variant-numeric: normal; font-variant-alternates: normal; font-variant-east-asian: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><span class="">Git: </span><a href="https://github.com/seamanticscience" class="">https://github.com/seamanticscience</a><span class=""><br class=""></span><div class="">___________________________________________________________________________</div></div></div></div></div></div></div></div></div></div></div></div></div></div>
</div>
<div><br class=""><blockquote type="cite" class=""><div class="">On Jul 30, 2021, at 7:52 AM, Hannah Kleppin <<a href="mailto:hkleppin@marum.de" class="">hkleppin@marum.de</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" class="">
<div class="">
<pre class="moz-quote-pre" wrap="">Dear MITgcm users and developers,
I'm currently working on the DIC package in a regional ocean model set-up and I'm trying to extend the DIC package for our purposes.
I had some problems with the values of pCO2 and the flux of CO2. I then realized that in the calculation of the stoichiometric solubility product of calcite and aragonite in the file dic_solvesaphe.F (line 844 and line 858) the natural logarithm of temperature is used (variable dlog_t_k, defined at line 440). I cannot access the reference paper (Mucci, 1983), but I think it should be Log10(t_k) (see e.g., the equic.m routine from Zeebe,Wolf-Gladrow at <a class="moz-txt-link-freetext" href="https://www.soest.hawaii.edu/oceanography/faculty/zeebe_files/CO2_System_in_Seawater/csys.html">https://www.soest.hawaii.edu/oceanography/faculty/zeebe_files/CO2_System_in_Seawater/csys.html</a>).
Using the log10 gives me at least realistic values of the stoichiometric solubility product of calcite, which showed before values of the order 10^224.
Furthermore I was wondering whether the units of omegaC (line 181 in calcite_saturation.F), the <span class="comment">local saturation state with respect to calcite, are correct. Probably I'm mistaken, but to me it looks as if Ksp_TP_calc is in [mol kg^-1-SW]^2, calcium</span><span class="comment"> in [mol kg^-1-SW], whereas carbonate </span>is converted back to [mol/m^3] (line 372 in dic_solvesaphe.F. This is maybe not the case if one uses the Follows formulation instead of the solvesaphe routines.).
Regards,
Hannah </pre>
</div>
_______________________________________________<br class="">MITgcm-support mailing list<br class=""><a href="mailto:MITgcm-support@mitgcm.org" class="">MITgcm-support@mitgcm.org</a><br class="">http://mailman.mitgcm.org/mailman/listinfo/mitgcm-support<br class=""></div></blockquote></div><br class=""></div></div></body></html>