<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">
Hi Kaitlin,
<div class=""><br class="">
</div>
<div class="">Thanks for taking the time to report this, and to track down what you think is causing it. The code base has recently moved to a <a href="https://github.com/MITgcm/MITgcm" class="">repository on GitHub</a> and we’d like to start using the issue
tracker there for dealing with bug reports - and discussing how to fix them. One advantage of using the GitHub issue tracker is that you can easily link to bits of code in the issue, and eventually the pull request that implements a fix can also link with
the original issue.</div>
<div class=""><br class="">
</div>
<div class="">If you’re willing to open an issue there, that’d be great.</div>
<div class=""><br class="">
</div>
<div class="">Cheers,</div>
<div class="">Ed</div>
<div class=""><br class="">
<div class="">
<div style="color: rgb(0, 0, 0); font-family: Palatino; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<span class="Apple-style-span" style="font-variant-ligatures: normal; font-variant-position: normal; font-variant-numeric: normal; font-variant-alternates: normal; font-variant-east-asian: normal; line-height: normal; border-collapse: separate; border-spacing: 0px;"><br class="Apple-interchange-newline">
<hr style="font-family: Tahoma; font-size: 13px;" class="">
<span class="Apple-style-span" style="font-family: Tahoma; font-size: 13px;"><font face="Tahoma" size="2" class=""><span dir="ltr" style="font-size: 10pt;" class=""><font size="1" class=""><span style="font-size: 13px;" class=""><font size="2" class=""><b class="">Edward
Doddridge</b><br class="">
<i class="">Postdoctoral researcher</i></font></span></font></span></font></span></span></div>
<div style="color: rgb(0, 0, 0); font-family: Palatino; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<span class="Apple-style-span" style="font-variant-ligatures: normal; font-variant-position: normal; font-variant-numeric: normal; font-variant-alternates: normal; font-variant-east-asian: normal; line-height: normal; border-collapse: separate; border-spacing: 0px;"><span class="Apple-style-span" style="font-family: Tahoma; font-size: 13px;"><font face="Tahoma" size="2" class=""><span dir="ltr" style="font-size: 10pt;" class=""><font size="1" class=""><span style="font-size: 13px;" class=""><font size="2" class=""><i class="">Earth,
Atmospheric and Planetary Sciences</i></font></span></font></span></font></span></span></div>
<div style="color: rgb(0, 0, 0); font-family: Palatino; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<span class="Apple-style-span" style="font-variant-ligatures: normal; font-variant-position: normal; font-variant-numeric: normal; font-variant-alternates: normal; font-variant-east-asian: normal; line-height: normal; border-collapse: separate; border-spacing: 0px;"><span class="Apple-style-span" style="font-family: Tahoma; font-size: 13px;"><font face="Tahoma" size="2" class=""><span dir="ltr" style="font-size: 10pt;" class=""><font size="1" class=""><span style="font-size: 13px;" class=""><font size="2" class=""><i class="">Massachusetts
Institute of Technology</i></font></span></font></span></font></span></span></div>
<div style="color: rgb(0, 0, 0); font-family: Palatino; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<div style="font-variant-ligatures: normal; font-variant-position: normal; font-variant-numeric: normal; font-variant-alternates: normal; font-variant-east-asian: normal; line-height: normal;" class="">
<span class="Apple-style-span" style="border-collapse: separate; font-variant-ligatures: normal; font-variant-position: normal; font-variant-numeric: normal; font-variant-alternates: normal; font-variant-east-asian: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; widows: 2; border-spacing: 0px;"><span class="Apple-style-span" style="font-family: Tahoma; font-size: 13px;"><font face="Tahoma" size="2" class=""><span dir="ltr" style="font-size: 10pt;" class=""><font size="1" class=""><span style="font-size: 13px;" class=""><font size="2" class=""><i class=""><br class="">
</i></font></span></font></span></font></span></span></div>
<div style="font-variant-ligatures: normal; font-variant-position: normal; font-variant-numeric: normal; font-variant-alternates: normal; font-variant-east-asian: normal; line-height: normal;" class="">
<span class="Apple-style-span" style="border-collapse: separate; font-variant-ligatures: normal; font-variant-position: normal; font-variant-numeric: normal; font-variant-alternates: normal; font-variant-east-asian: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; widows: 2; border-spacing: 0px;"><span class="Apple-style-span" style="font-family: Tahoma; font-size: 13px;"><font face="Tahoma" size="2" class=""><a href="http://www.doddridge.me" class="">www.doddridge.me</a></font></span></span></div>
</div>
</div>
<div><br class="">
<blockquote type="cite" class="">
<div class="">On 8 May 2018, at 09:50, Naughten, Kaitlin A. <<a href="mailto:kaight@bas.ac.uk" class="">kaight@bas.ac.uk</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div id="divtagdefaultwrapper" dir="ltr" style="caret-color: rgb(0, 0, 0); font-size: 12pt; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; font-family: Calibri, Helvetica, sans-serif;" class="">
<div style="margin-top: 0px; margin-bottom: 0px;" class="">Hello,</div>
<div style="margin-top: 0px; margin-bottom: 0px;" class=""><br class="">
</div>
<div style="margin-top: 0px; margin-bottom: 0px;" class="">I'm writing to report a small bug in<span style="font-size: 12pt;" class=""> the MNC masking option (useMissingValue in data.diagnostics). When I switch this option on, ice shelf diagnostics (SHIfwFlx,
SHIhtFlx, SHIuStar) are incorrectly masked. The entire ice shelf is masked out, with only the open ocean (where these variables are zero) unmasked.</span></div>
<div style="margin-top: 0px; margin-bottom: 0px;" class=""><span style="font-size: 12pt;" class=""><br class="">
</span></div>
<div style="margin-top: 0px; margin-bottom: 0px;" class=""><span style="font-size: 12pt;" class="">In the subroutine diagnostics_mnc_out, it looks like maskC is applied at klev=1, since the ice shelf variables have already been compressed into a 2D array. But
in fact this 2D array represents all different values of klev, none of which are 1 beneath the ice shelf.</span></div>
<div style="margin-top: 0px; margin-bottom: 0px;" class=""><span style="font-size: 12pt;" class=""><br class="">
</span></div>
<div style="margin-top: 0px; margin-bottom: 0px;" class=""><span style="font-size: 12pt;" class="">I'm not sure of the most efficient way to solve this problem, as I'm not very familiar with the code base yet, so I thought I'd report it here before I tried
to fix it myself! If someone sees an obvious solution, I'm happy to implement it.</span></div>
<div style="margin-top: 0px; margin-bottom: 0px;" class=""><span style="font-size: 12pt;" class=""><br class="">
</span></div>
<div style="margin-top: 0px; margin-bottom: 0px;" class="">Many thanks,</div>
<div style="margin-top: 0px; margin-bottom: 0px;" class="">Kaitlin Naughten</div>
</div>
<hr style="caret-color: rgb(0, 0, 0); font-family: Palatino-Roman; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">
<small style="caret-color: rgb(0, 0, 0); font-family: Palatino-Roman; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">This
message (and any attachments) is for the recipient only. NERC is subject to the Freedom of Information Act 2000 and the contents of this email and any reply you make may be disclosed by NERC unless it is exempt from release under the Act. Any material supplied
to NERC may be stored in an electronic records management system</small><span style="caret-color: rgb(0, 0, 0); font-family: Palatino-Roman; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">.</span>
<hr style="caret-color: rgb(0, 0, 0); font-family: Palatino-Roman; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">
<span style="caret-color: rgb(0, 0, 0); font-family: Palatino-Roman; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">_______________________________________________</span><br style="caret-color: rgb(0, 0, 0); font-family: Palatino-Roman; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">
<span style="caret-color: rgb(0, 0, 0); font-family: Palatino-Roman; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">MITgcm-support
mailing list</span><br style="caret-color: rgb(0, 0, 0); font-family: Palatino-Roman; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">
<a href="mailto:MITgcm-support@mitgcm.org" style="font-family: Palatino-Roman; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">MITgcm-support@mitgcm.org</a><br style="caret-color: rgb(0, 0, 0); font-family: Palatino-Roman; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">
<a href="http://mailman.mitgcm.org/mailman/listinfo/mitgcm-support" style="font-family: Palatino-Roman; font-size: 16px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">http://mailman.mitgcm.org/mailman/listinfo/mitgcm-support</a></div>
</blockquote>
</div>
<br class="">
</div>
</body>
</html>