[MITgcm-support] Rapid vote on EXF_OPTIONS.h versus EXF_CPPOPTIONS.h

Patrick Heimbach heimbach at MIT.EDU
Tue Oct 7 13:57:20 EDT 2003



Alistair Adcroft wrote:
> Sorting out inter-package dependencies *is* worth spending time on because
> it's currently a bloody mess:
>  x It appears that EXF, CAL and ECCO options are being set in several
> different places (including all in ECCO_CPPOPTIONS). E.g.
>    USE_EXF_INTERPOLATION  is #ifdef'd only in exf_*.[hF] but only #define'd
> in ECCO_CPPOPTIONS.h

Don't know about USE_EXF_INTERPOLATION,
but all EXF, CAL, COST, CTRL, AUTODIFF, ECCO related CPP options
currently should ONLY go into one single header file,
ECCO_CPPOPTIONS
(see e.g. verification/global_with_exf/ in the main branch).

It is true that all other OPTIONS files EXF_... CAL_...
are currently redundant.
We can discuss the reasons for this when you're around,
rather than filling mail boxes.

-p.

>  x Most copies of *OPTIONS.h files in code/ are redundant (no different the
> one in pkg/ except for missing #includes and stuff
>  X The list goes on...
> 
> I agree about the impact on users but R2 is the only opportunity to get this
> cleaned up.
> 
> BTW, CPP_OPTIONS.h is now retired so users already have to deal with this.
> 
> A.
> --
> Dr Alistair Adcroft            http://www.mit.edu/~adcroft
> MIT Climate Modeling Initiative        tel: (617) 253-5938
> EAPS 54-1523,  77 Massachusetts Ave,  Cambridge,  MA,  USA
> 
> -----Original Message-----
> From: mitgcm-support-bounces at mitgcm.org
> [mailto:mitgcm-support-bounces at mitgcm.org] On Behalf Of Patrick Heimbach
> Sent: Tuesday, October 07, 2003 12:14 PM
> To: mitgcm-support at mitgcm.org
> Subject: Re: [MITgcm-support] Rapid vote on EXF_OPTIONS.hversus
> EXF_CPPOPTIONS.h
> 
> 
> I guess, the vote initiator will be responsible
> for the cleanup, both in the main and the ecco-branch.
> 
> And while he's at it, also change
> CAL_CPPOPTIONS
> AUTODIFF_CPPOPTIONS
> ECCO_CPPOPTIONS
> 
> And communicate those changes to the ECCO users
> who keep their separate header files.
> 
> Aren't there more important things to spend time on?
> 
> -p.
> 
> Ed Hill wrote:
> 
>>On Tue, 2003-10-07 at 11:45, Alistair Adcroft wrote:
>>
>>
>>>In the spirit of Californian elections lets have a rapid vote 
>>>(decision in 30 mins) on whether EXF_CPPOPTIONS.h is renamed 
>>>EXF_OPTIONS.h or stays as is.  The norm is not to have CPP in the name 
>>>but how much headache will I get if I've made the change (I already 
>>>did it inadvertently).
>>>
>>>Cast your votes!
>>
>>
>>
>>Heres one vote for a clean sweep ("EXF_OPTIONS.h").
>>
>>Ed
>>
>>
>>
>>----------------------------------------------------------------------
>>--
>>
>>_______________________________________________
>>MITgcm-support mailing list
>>MITgcm-support at mitgcm.org 
>>http://dev.mitgcm.org/mailman/listinfo/mitgcm-support
> 
> 
> 


-- 
Patrick Heimbach ........................... M.I.T
FON: +1/617/253-5259 .......... EAPS, Room 54-1518
FAX: +1/617/253-4464 ..... 77 Massachusetts Avenue
mailto:heimbach at mit.edu ....... Cambridge MA 02139
http://www.mit.edu/~heimbach/ .............. U.S.A




More information about the MITgcm-support mailing list