[Mitgcm-support] no subject

[mitgcm-support at dev.mitgcm.org]

Hi there,

a few remarks concerning recent developments.

I took the version ecco_c30_armin that Armin kindly provided,
and which, I understand, contains some bug fixes of
Ralf's version ecco_c30_ralf and of Dimitris' kpp package.
To major things:

1. GM
-----
The version ecco_c30_ralf misses the whole
Gent&McWilliams package, which should be under
./pkg/gmredi
This version therefore doesn't run with GM,
and obviously is not adjointable for GM.

2. Packages - so far
-----------
- There have been ambiguities in the past for changing files
  that belonged to packages.
  Some changes were made in ./model/src/...,
  others were made in ./pkg/${pkg}/...
  obviously leading to confusion.
  To avoid this, and to stick closer to the package structure,
  all routines belonging to packages are now removed from ./model/src/.
  and put under ./pkg/${pkg}/.
  Likewise, all header and CPP option files belonging to packages
  are now moved from ./model/inc/. to ./pkg/${pkg}/.

- ./tools/genmake and ./wrk/makefile are adapted accordingly.

- Packages that either
  * are not yet used (diva, sph, diagnos)
  * belong to offline optimization (optim, lsopt)
  were moved to ./pkg/offline
(I actually did that and wrote that 3 weeks ago before leaving,
but probably nobody read it.)

I did further changes to the package_...F files
(see my previous e-mail) as well as to the files
initialise_fixed.F, initialise_varia.F

I'll put everything on the CVS tree tomorrow
and prepare a new tar file.
I know that you won't be happy to look into yet another version,
but it seems the only way so far to get back to a common version.
The one that will be under the CVS is very close to ecco_c30_armin.

... Armin,
just got your mail concerning the factor 0.01 in KPP_calc.F.
I'll include it in my kpp package, but ask you to check whether
what I'll put on the web tomorrow is OK.

Here's a (probably not complete) list of files were 
changes were made:

(A) ./pkg/
included the whole gmredi package

(b) ./model/src
packages_boot.F (NEW)
packages_readparms.F (NEW)
packages_check.F
packages_init.F

initialised_fixed.F
initialised_varia.F

dynamics.F

(c) ./pkg/ecco
ecco_init.F (new meaning)
ecco_readparms.F (NEW)

(d) ./pkg/gmredi/ ./pkg/kpp/
replaced variables   use_kppmixing  ->  useKPP
                     use_gmredi    ->  use GMRedi
plus a few minor changes
          
kpp_readparms.F (NEW)
kpp_init.F

(E)
./model/inc/PARAMS.h
./tools/genmake (up-to-date with MITgcmUV c30)
./wrk/makefile (included gmredi routines)

Cheers
Patrick
___________________________________________________________________
Patrick Heimbach                        Phon: +1 / 617 / 253 - 5259
Massachusetts Institute of Technology   Facs: +1 / 617 / 253 - 4464 
EAPS, Room 54-1518
77 Massachusetts Avenue                     mailto:heimbach at mit.edu
Cambridge MA 02139, U.S.A.            http://www.mit.edu/~heimbach/