[MITgcm-devel] optim_m1qn3

[Martin Losch]

Hi Dan,

I just downloaded optim_m1qn3 and tried to compile it (pointing it to tutorial_global_oce_optim) and I could compile it without including “CTRL_SIZE.h”.

Then I tried verification/OpenAd, but that does not work for me, because I have not yet openad installed and so everything is very bumpy and I don’t get to the point where I would need CTRL_SIZE.h, but it seem plausible that you need it when using OPENAD and  ALLOW_GENARR2/3D_CONTROL, because then you need the sizes of the xx_genarr. 
I tried to fix this now, but please check, if it works.

I noticed a problem with ctrl.h: in line 310, there’s a comma missing, should be:
      common /controlvars_r_openad/
     &        xx_place_holder
# ifdef ECCO_CTRL_DEPRECATED
     &      , xx_theta
…

Maybe you can fix that? Or Gael?

Martin


> On 06 May 2016, at 16:38, Daniel Goldberg <dngoldberg at gmail.com> wrote:
> 
> Hi Martin
> 
> I am compiling your version of optim_m1qn3 in contrib, and I think this might be my first time using it with an OpenAD experiment (otherwise I am very confused). I needed to insert 
> 
> #include "CTRL_SIZE.h"
> 
> before any inclusion of ctrl.h to get the code to compile. It seems as though this is only an issue with ALLOW_OPENAD. I just want to confirm this will not affect the results of the m1qn3 algorithm?
> 
> Many thanks
> Dan
> 
> 
> 
> -- 
> 
> Daniel Goldberg, PhD
> Lecturer in Glaciology
> School of Geosciences, University of Edinburgh
> Geography Building, Drummond Street, Edinburgh EH8 9XP
> 
> 
> em: Dan.Goldberg at ed.ac.uk
> web: http://ocean.mit.edu/~dgoldberg
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel