[MITgcm-devel] cost_gencost_seaicev4 (small) bugfix

[An Nguyen]

Hi all,

In updating this subroutine to the latest code to make full use of Gael's recent gencost framework, I've discovered a (small) bug pertaining to how we tally the number of points (num_gencost) for the two proxy costs in here, so this is a heads up that I'll check in a bug-fix tomorrow.

More info:
Normally, the way we calculate cost and tally the number of points is by using a mask to filter out land + invalid obs points.  In this subroutine, there are 3 costs:
1. the main sea-ice concentration cost: has been correctly masked for both cost + num tally
2&3: [de,ex]conc: mask was applied correctly for cost, but was not used (this is the bug) in num tally , so the num tally has been overestimated.

Part of the code-update is to make use of the subroutine ecco_addcost (inside ecco_toolbox.F), and this is how i found out 2&3 have not been mannually masked correctly: kept getting the tally wrong, now after my bug-fix of original code i can reproduce tally identically.

Again, it does not affect total cost for any term, just the num_gencost for the two proxies above.

cheers,
An