[MITgcm-devel] old pkg/ecco routines

[Matthew Mazloff]

Great -- thanks for the implementation advice!

Matt


On Oct 27, 2015, at 2:33 PM, gael forget <gforget at mit.edu> wrote:

> Hi Matt,
> 
> thanks for the quick feedback.
>> I can implement this in the future if you want -- seems straightforward.  In the meantime, you can remove these files, as yes, they don't even work in the current code tree configuration.
> ok. I will remove them then. 
> 
>> (And just as a heads up, in the near future I will be using tomography in the profile package and if it seems appropriate I will check in my code.)
> cool. To the extent that this is possible, please try to follow the example of m_eta, m_UE, m_VN:
> compute the needed 2D/3D fields (e.g., sound speed) in pkg/ecco/ecco_phys.F and store them 
> in pkg/ecco/ecco.h common blocs. This way the fields are immediately available for generic cost 
> function terms in pkg/ecco and pkg/profiles and things will stay orderly.
> 
> Cheers,
> Gael
> 
>> Thanks!
>> Matt
>> 
>> 
>> On Oct 27, 2015, at 12:20 PM, gael forget <gforget at mit.edu> wrote:
>> 
>>> Dear all,
>>> 
>>> following the recent revisions in pkg/ecco a first set of 
>>> routines is about to get physically removed (listed under C below)
>>> since they have been replaced with generic calls (codes listed under A).
>>> 
>>> My question pertains to the routines listed under D below that 
>>> I think are candidates for the next round of removals:
>>> - which ones can be declared dead and ok for removal?
>>> - which ones do you still use and remain needed?
>>> 
>>> Cheers,
>>> Gael
>>> 
>>> A) general purpose codes that is routinely tested
>>> ———————————————————————————————
>>> 
>>> cost_averagesfields.F
>>> cost_averagesflags.F
>>> cost_averagesgeneric.F
>>> cost_averagesinit.F
>>> cost_gencal.F
>>> cost_gencost_all.F
>>> cost_gencost_assignperiod.F
>>> cost_gencost_boxmean.F
>>> cost_gencost_bpv4.F
>>> cost_gencost_customize.F
>>> cost_gencost_seaicev4.F
>>> cost_gencost_sshv4.F
>>> cost_gencost_sstv4.F
>>> cost_generic.F
>>> cost_genread.F
>>> ecco_check.F
>>> ecco_cost_driver.F
>>> ecco_cost_final.F
>>> ecco_cost_init_barfiles.F
>>> ecco_cost_init_fixed.F
>>> ecco_cost_init_varia.F
>>> ecco_cost_summary.F
>>> ecco_cost_weights.F
>>> ecco_init_varia.F
>>> ecco_phys.F
>>> ecco_readparms.F
>>> ecco_summary.F
>>> ecco_toolbox.F
>>> 
>>> B) non-generic code that remains tested
>>> ———————————————————————————————
>>> 
>>> cost_forcing.F
>>> cost_hyd.F
>>> cost_internal_params.F
>>> cost_sla_read.F
>>> cost_sla_read_yd.F
>>> cost_ssh.F
>>> cost_bp_read.F
>>> 
>>> cost_obcs_ageos.F
>>> cost_obcse.F
>>> cost_obcs.F
>>> cost_obcsn.F
>>> cost_obcss.F
>>> cost_obcsvol.F
>>> cost_obcsw.F
>>> 
>>> C) codes that have been replaced with generic function calls and is about to be physically removed
>>> ———————————————————————————————
>>> 
>>> 
>>> cost_argo_salt.F
>>> cost_argo_theta.F
>>> cost_bp.F
>>> cost_ctdsclim.F
>>> cost_ctds.F
>>> cost_ctdtclim.F
>>> cost_ctdt.F
>>> cost_readargos.F
>>> cost_readargot.F
>>> cost_readers.F
>>> cost_readgfo.F
>>> cost_readtopex.F
>>> cost_readtopexmean.F
>>> cost_salt.F
>>> cost_theta.F
>>> cost_xbt.F
>>> 
>>> cost_diffkr.F
>>> cost_etan0.F
>>> cost_bottomdrag.F
>>> cost_kapgm.F
>>> cost_kapredi.F
>>> cost_salt0.F
>>> cost_theta0.F
>>> cost_uvel0.F
>>> cost_vvel0.F
>>> 
>>> D) legacy codes that may or may not be useful
>>> —————————————————————
>>> 
>>> 1) not called anywhere
>>> cost_geoid.F
>>> cost_readgeoid.F 
>>> cost_ies.F
>>> cost_ies_read.F
>>> cost_store_averagesflags.F
>>> cost_restore_averagesflags.F
>>> cost_tau_eddy.F
>>> cost_ssh_mean.F
>>> cost_usercost_all.F		(G.F.: dead)
>>> cost_sshv4.F			(G.F.: dead)
>>> 
>>> 2) not tested but call exists in cost_averagesfields.F
>>> cost_atlantic.F
>>> 
>>> 3) not tested but call exists in cost_hyd.F
>>> cost_gen_transport.F
>>> cost_sigmar.F			(A.N.: dead)
>>> 
>>> 4) not tested but call exists in ecco_cost_final.F
>>> cost_trans_merid.F
>>> cost_trans_zonal.F
>>> 
>>> 5) not tested but call exists in ecco_cost_driver.F
>>> cost_curmtr.F
>>> cost_drifter.F
>>> cost_drift.F
>>> cost_driftw.F
>>> cost_mean_heatflux.F
>>> cost_mean_saltflux.F
>>> cost_scat.F
>>> 	+cost_readscatxfields.F
>>> 	+cost_readscatyfields.F
>>> cost_salt_ini_fin.F
>>> cost_theta_ini_fin.F
>>> cost_ssh_new.F
>>> 
>>> _______________________________________________
>>> MITgcm-devel mailing list
>>> MITgcm-devel at mitgcm.org
>>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>> 
>> _______________________________________________
>> MITgcm-devel mailing list
>> MITgcm-devel at mitgcm.org
>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
> 
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mitgcm.org/pipermail/mitgcm-devel/attachments/20151027/7aadef68/attachment-0001.htm>