[MITgcm-devel] [MITgcm-cvs] MITgcm/pkg/layers CVS Commit

[Ryan Abernathey]

I believe I fixed everything with my latest commit. The testreport errors
were because I forgot to commit the new file I had added
(layers_wsurf_tr.F). I also restored the name of LaTr?RHO and replaced my
diagnostic of the same name with LaTz?RHO.

Sorry again for the problems.

-Ryan

On Wed, Jun 3, 2015 at 12:58 PM, Ryan Abernathey <ryan.abernathey at gmail.com>
wrote:

> Jean Michel,
>
> Please accept my sincere apologies for causing these problems.
>
> I changed the name of LaTr#RHO to La#RHO because, in my new diagnostics
> for LAYERS_THERMODYNAMICS, I introduced the name LaTr#RHO completely
> independently and unaware of your new diagnostic with the same new. (This
> was a consequence of allowing my branch to become out of sync with the main
> branch while I was developing it.)
>
> My naming choice was part of a larger scheme, including the following
> diagnostics
> LaTs: Layer THETA transformation from surf. forc.
> LaTh: Layer THETA transformation from horiz. diff.
> LaTr: Layer THETA transformation from vert. diff.
> LaSs: Layer SALT transformation from surf. forc.
> LaSh: Layer SALT transformation from horiz. diff.
> LaSr: Layer SALT transformation from vert. diff.
>
> As you requested, I will restore the old name of LaTr#RHO for the
> potential density field. However, I will have to change the name of my new
> diagnostics to allow this. As for the whitespace, that was just a mistake.
>
> As for the broken cfc_example, I did indeed check carefully it before
> checking in my code. I am looking again now to see what went wrong.
>
> I am working on this now and will check in a fixed version of the code
> asap, hopefully within an hour or two.
>
> I always manage to screw something up whenever I try to check code in...
>
> -R
>
>
> On Wed, Jun 3, 2015 at 11:53 AM, Jean-Michel Campin <jmc at ocean.mit.edu>
> wrote:
>
>> Hi Ryan,
>>
>> I have a problem with renaming diagnostic "LaTr#RHO" to "La  #RHO" in
>> layers_calc.F:
>> a) it's not great to have white space within diagnostics name ;
>> b) this name change is not implemented in layers_diagnostics_init.F (this
>> diagnostics
>>   is currently broken);
>> c) I added this diagnostics few weeks ago ; I don't know why you want
>>   to change it but we can discuss this ; and this was not in the set of
>>   changes you sent me yesterday.
>> I would like to put back the previous diagnostics name (LaTr#RHO).
>>
>> And there a a second problem:
>> the forward testreport fail to compile experiments exp4 & cfc_example.
>> (I did check the Adjoint testreport yesterday but not the forward which I
>> thought
>> was OK according to your earlier email).
>> Could you fix this problem today ?
>>
>> Cheers,
>> Jean-Michel
>>
>> On Wed, Jun 03, 2015 at 09:39:22AM -0400, Ryan Abernathey wrote:
>> > Update of /u/gcmpack/MITgcm/pkg/layers
>> > In directory forge:/tmp/cvs-serv14197/pkg/layers
>> >
>> > Modified Files:
>> >       LAYERS.h layers_calc.F layers_diagnostics_init.F
>> >       layers_fluxcalc.F layers_init_fixed.F layers_init_varia.F
>> >       layers_save.F layers_thermodynamics.F
>> > Log Message:
>> > Fixed bug in layers_fluxcalc.F regarding incorrect interpolation with
>> >  partial cells.
>> > Enhanced the LAYERS_THERMODYNAMICS diagnostic options.
>> > Renamed LaTr... diagnostic to La...
>> >
>> >
>> >
>> > _______________________________________________
>> > MITgcm-cvs mailing list
>> > MITgcm-cvs at mitgcm.org
>> > http://mitgcm.org/mailman/listinfo/mitgcm-cvs
>>
>> _______________________________________________
>> MITgcm-devel mailing list
>> MITgcm-devel at mitgcm.org
>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mitgcm.org/pipermail/mitgcm-devel/attachments/20150603/8a9e0413/attachment.htm>