[MITgcm-devel] [MITgcm-cvs] MITgcm/pkg/shelfice CVS Commit

[Daniel Goldberg]

Hi Jean Michel

I have looked into the OAD experiment and seems that drLoc from
shelfic_forcing.F (where ShelficeBoundaryLayer = .TRUE.) is negative (and
small) in some places, but somehow my change to set it to zero does not
affect the forward results. The adjoint results are affected -- but the
gradient checks are still accurate (accuracies 1e-8 to 1e-9 range).

Thus I think the changes are ok, as Martin was fine with the change, unless
you think otherwise. I will check in the new results_oadm.txt on
baudelaire. I wonder if you could possibly run TAF and check in the results
-- as long as the gradient check accuracies are still small? (if they are
not still small let me know, i will figure out a way to fix this.)

Thanks
Dan

On Thu, Apr 23, 2015 at 3:54 PM, Jean-Michel Campin <jmc at ocean.mit.edu>
wrote:

> Hi Dan,
>
> The three AD isomip test (2 TAF, 1 OpenAD) have changed, and it's very
> likely due to the changes you made yesterday:
>
> On baudelaire with gfortran (=reference platform):
> OpenAD
>  Y Y Y Y 11> 9< 8 FAIL  isomip
> TAF:
>  Y Y Y Y 11> 9< 8 FAIL  isomip  (e=0, w=4)
>  Y Y Y Y 12>11< 9 FAIL  isomip.htd
> (previously, was all 16)
>
> Can you try to identify which modification is responsible for these
> changes and check if this was expected (in which cae we will need to update
> the reference output) or if there is something to fix in the modified code.
>
> Cheers,
> Jean-Michel
>
> On Wed, Apr 22, 2015 at 09:12:19AM -0400, Daniel N. Goldberg, 54-1423,
> 6172532977,  wrote:
> > Update of /u/gcmpack/MITgcm/pkg/shelfice
> > In directory forge:/tmp/cvs-serv5262
> >
> > Modified Files:
> >       shelfice_forcing.F shelfice_thermodynamics.F
> > Log Message:
> > limit effects of shelficeboundarylayer to where hFacC(kTopC)<1
> >
> >
> > _______________________________________________
> > MITgcm-cvs mailing list
> > MITgcm-cvs at mitgcm.org
> > http://mitgcm.org/mailman/listinfo/mitgcm-cvs
>



-- 

Daniel Goldberg, PhD
Lecturer in Glaciology
School of Geosciences, University of Edinburgh
Geography Building, Drummond Street, Edinburgh EH8 9XP


em: D <dgoldber at mit.edu>an.Goldberg at ed.ac.uk
web: http://ocean.mit.edu/~dgoldberg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mitgcm.org/pipermail/mitgcm-devel/attachments/20150423/0daab4f8/attachment.htm>