[MITgcm-devel] pkg/streamice

[Daniel Goldberg]

Hi Jean Michel

On Thu, Sep 11, 2014 at 7:52 AM, Jean-Michel Campin <jmc at ocean.mit.edu>
wrote:

> Hi Dan,
>
> 2 things about pkg/streamice:
>
> 1) I would like to move the call to streamice_initialise_petsc
>  from the_model_main.F to the top of streamice_init_fixed.F
>  (it would be a better place for such an initialisation).
>  The only relevant streamice call in between is streamice_readparms.F
>  and I don't think petscInitialize has any overlap with
> streamice_readparms.
>  Can you confirm ?
>

i think this is fine. i don't think there are any petsc calls before
packages_init_fixed.

note there is still a call to streamice_finalize_petsc in the_model_main,
and i don't know a good place to hide this, since there are no
"packages_cleanup" calls or anything like that..


>
> 2) in streamice_readparms.F, it seem that you removed during revision 1.5
>  (on Jun 04, 2014) all the changes I made at revision 1.4 (on May 27,
> 2014).
>  Can you explain why you remove this modification ?
>
>  Since this was about calling STREAMICE_READPARMS even when
>  useSteamIce=F , I added, at the same time, at the top of
> streamice_readparms.F,
>  something like: IF (.NOT.useSteamIce ) RETURN
>  now this quick return is gone but STREAMICE_READPARMS is still called
>  when useSteamIce=F
>

i apologize. i would not have done this -- the only possibility is i was
not making changes to an updated version. do you mean the lines 146-154 of
version 1.4? Shall i add these back in? i am not sure what they are meant
to do, will it impact anything else?


> Cheers,
> Jean-Michel
>
>
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>



-- 

Daniel Goldberg, PhD
Lecturer in Glaciology
School of Geosciences, University of Edinburgh
Geography Building, Drummond Street, Edinburgh EH8 9XP


em: D <dgoldber at mit.edu>an.Goldberg at ed.ac.uk
web: http://ocean.mit.edu/~dgoldberg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mitgcm.org/pipermail/mitgcm-devel/attachments/20140911/f7fa2847/attachment.htm>