[MITgcm-devel] ALLOW_3D_DIFFKR warnings

[Jean-Michel Campin]

Hi,

Recently, 2 different users reported wasted time / CPU / effort 
trying to change diffKrT (or diffKrNrT) but without seeing any effect 
on the solution. The reason was simply due to ALLOW_3D_DIFFKR beeing defined.

I propose to add a stop in ini_parms.F to avoid this type of error/mistake. 
It would stop if one of the diffKr/p/zT or diffKrNrT is set but not used 
(because of ALLOW_3D_DIFFKR); and a similar (but not identical) stop
for diffKr/p/zS and diffKrNrS.

Now looking at the new AD testreport results, it seems that I will have to 
update also few verification/*/input_ad*/data files

I could also change the STOP to just a warning (also I have the impression
that some users don't pay much attention to warnings).
Any comment on this ?

Cheers,
Jean-Michel