[MITgcm-devel] [MITgcm-cvs] MITgcm/pkg/shelfice CVS Commit

[Jean-Michel Campin]

Hi Dan,

Regarding your recent changes (from yesterday) in pkg/shelfice:

1) it should be documented in doc/tag-index

2) I would like to propose to rename few variables:
a) the run-time logical parameter which activates the changes in ice-mass
  (stepping forward "shelficeMass" field) is currently "SHELFICEallowThinIceMass"
  but I was concern it could be confused with some special treatment 
  related to regions/column where the ice-shelf is thin. 
  Instead, I would propose a name which contains "stepping" like we
  have for temperature, salinity, momentum, ...
  like, for example, shelfIceMassStepping.
b) the new field (+ file name to read-in)
   shelficeMassDynamics (and SHELFICEDynamicsFile)
  can stay the same, but since pkg/shelfice is not doing any ice dynamics, 
  might also think about including explicitly "tendency" in the variable name
  such as shelfIceMassDynTendency and SHELFICEMassDynTendFile.
  
 Of course, if you have other suggestions for new names, they are welcomed.  
 I could also make some of these renaming (once we agree) using some scripts, 
 if you prefer.

3) I propose to move the #ifdef ALLOW_STREAMICE block from
  shelfice_thermodynamics.F into the new routine shelfice_step_icemass.F
  since it's also about stepping forward shelficeMass;
  and add "IF ( useStreamIce ) THEN / ENDIF" condition ; 
  This would also avoid to modify shelfice_thermodynamics.F every time
  streamice coupling changes.
  I can make this modification if you agree.

Cheers,
Jean-Michel

On Fri, Dec 19, 2014 at 01:09:33PM -0500, Daniel N. Goldberg, 54-1423, 6172532977,  wrote:
> Update of /u/gcmpack/MITgcm/pkg/shelfice
> In directory forge:/tmp/cvs-serv27659
> 
> Added Files:
> 	shelfice_step_icemass.F 
> Log Message:
> update shelficemass based on FWflux and input file (for ice dynamics)
> 
> 
> _______________________________________________
> MITgcm-cvs mailing list
> MITgcm-cvs at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-cvs