[MITgcm-devel] filename issue when packing controls with mdsioLocaldir

[Daniel Goldberg]

On Mon, Apr 28, 2014 at 8:26 PM, Patrick Heimbach <heimbach at mit.edu> wrote:

>
> Hi Dan,
>
> I don’t think I understood your email.
> Why would you want to have white spaces in a filename?
> Also, a detailed bug report would be more useful.
>

Sorry for the confusing description.

I am fairly sure the bug is caused by this call within ctrl_set_pack_xy.F
(but need to test further to be certain):

      call MDSREADFIELD_3D_GL(
     &     masktype, ctrlprec, 'RL',
     &     Nr, globmsk, 1, mythid)

and then on line 132 of mdsio_gl.F:

      write(fName,'(2a)') mdsioLocalDir(1:pIL), fName(1:IL)

is causing it to fail if pIL>0, but I am not sure why. mdsio_gl.F has not
been changed recently, so I am wondering if previously MASKTYPE previously
had trailing whitespace which would allow for the extra characters to be
appended, but has been removed in recent updates.



>
> Another thing:
> I noticed the halfpipe_streamice experiment is now failing (has been for
> some time?).
> Accuracies of the gradient aren’t as good as they used to be.
>

on which machine are the results you're looking at run? TAF or OpenAD?


> Do you know what has changed?
>

the only major thing is that I added an advancing ice front to the test,
but I produced a new results file. this was a few months back...


>
> Cheers
> p.
>
> On Apr 26, 2014, at 6:05 AM, Daniel Goldberg <dngoldberg at gmail.com> wrote:
>
> > Hi All
> >
> > On Matt Mazloff's suggestion I have been using ALLOW_PACKUNPACK_METHOD2
> to allow for the control package to work while using mdsioLocalDir, and it
> was working until I did a fresh checkout two days ago. The bug seems to be
> occurring at line 132 of mdsio_gl.F:
> >
> >  write(fName,'(2a)') mdsioLocalDir(1:pIL), fName(1:IL)
> >
> > where the S/R is called for ctrlMaskC. The input arg fname has been
> declared as
> >
> >  character*(*) fName
> >
> > and there is no whitespace. Perhaps there was whitespace before and that
> allowed for the above line of code to execute, and now it has been clipped?
> I could be completely off though, but I was able to use mdsioLocalDir
> without issue before my most recent checkout (prior checkout was ~ 2 months
> ago).
> >
> > Many thanks
> > Dan
> >
> > --
> >
> > Daniel Goldberg, PhD
> > Lecturer in Glaciology
> > School of Geosciences, University of Edinburgh
> > Geography Building, Drummond Street, Edinburgh EH8 9XP
> >
> >
> > em: Dan.Goldberg at ed.ac.uk
> > web: http://ocean.mit.edu/~dgoldberg
> > _______________________________________________
> > MITgcm-devel mailing list
> > MITgcm-devel at mitgcm.org
> > http://mitgcm.org/mailman/listinfo/mitgcm-devel
>
>
> ---
> Patrick Heimbach | heimbach at mit.edu | http://www.mit.edu/~heimbach
> MIT | EAPS 54-1420 | 77 Massachusetts Ave | Cambridge MA 02139 USA
> FON +1-617-253-5259 | FAX +1-617-253-4464 | SKYPE patrick.heimbach
>
>
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>
>


-- 

Daniel Goldberg, PhD
Lecturer in Glaciology
School of Geosciences, University of Edinburgh
Geography Building, Drummond Street, Edinburgh EH8 9XP


em: D <dgoldber at mit.edu>an.Goldberg at ed.ac.uk
web: http://ocean.mit.edu/~dgoldberg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mitgcm.org/pipermail/mitgcm-devel/attachments/20140428/23d74369/attachment.htm>