[MITgcm-devel] pkg/ecco sshv4 MDT vs tpmean vs ssh mean

[An T Nguyen]

hello again,

We have places in the ecco package where various names of flag/cost/file/variable are used for the mean dynamic topography (MDT), e.g., ssh mean, mdt, topexmean, which can be quite confusing (at least for me when I started using ecco package 1 year ago and trying to keep track of topexcost vs mdtcost vs slacost vs sshcost).   This is an example from ecco_check.F:
#ifdef ALLOW_SSH_MEAN_COST_CONTRIBUTION
      CALL ECCO_CHECK_FILES( using_cost_altim,
     & 'mdt', topexmeanfile, modelstartdate(1), myThid ) 
#endif
Since MDT can be derived from more sources than just topex, I propose cleaning up and separating the "tp" from MDT variables/names, e.g., topexmeanfile -> mdtfile, tpmean_yr -> mdt_yr..  

What are your thoughts?

It turns out I have done most of (1) already since May 2013 in my version of code, as part of my effort to move the hard-coded mdt year range (tpmean_yr[0/1] in cost_gencost_sshv4.F) to run-time parameters mdtstartdate and mdtenddate in data.ecco.   I think it would make the code cleaner and easier to follow (at least for me).  Since I have done most of the work already, am familiar with the package now, can take care of switching names in the same manner as in seaicev4 + running testreports + longer tests for llc90, it would be a good time to address this in term of effort.

cheers,
An

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mitgcm.org/pipermail/mitgcm-devel/attachments/20140403/e6e9ad0c/attachment.htm>