[MITgcm-devel] [MITgcm-cvs] MITgcm/eesupp/src CVS Commit

[Menemenlis, Dimitris (3248)]

Jean-Michel thanks for taking a look.
I am still experimenting with this on lustre and pleiades
so will wait until it works before I modify again.
But I will definitely follow your advice below,
or revert  to old version if I don't succeed.

Two questions:

1- Do we need to write scratch2 to disk?
Seems to be identical to original parameter files.

2- Is it OK to use
CALL MPI_BARRIER( MPI_COMM_MODEL, mpiRC )
in open_copy_data_file.F?

Sorry I thought this would be a trivial change
but seems like I opened a small can of worms.
I should not have checked in code so carelessly.

Dimitris Menemenlis

On Sep 29, 2013, at 9:51 AM, Jean-Michel Campin wrote:

> Hi Dimitris,
> 
> I took a quick look at the pieces you added:
> 1) in open_copy_data_file.F:
> this S/R is always (from what I know) called by master thread only,
> so that adding a _BARRIER in it will always break the multi-threaded
> run. 
> Also, does not seems to use "mpiRC" that you added, and 
> not sure why we need to add #include "EESUPPORT.h"
> 2) in eeset_parms.F:
> this S/R is sometimes called directly from eeboot_minimal.F,
> before myProcId being set. 
> Could you a STOP like this:
>  IF ( .NOT.doReport ) STOP 'ABNORMAL END: S/R EESET_PARMS: myProcId unset'
> within #ifdef SINGLE_DISK_IO / #endif
> before using myProcId
> 
> Cheers,
> Jean-Michel