[MITgcm-devel] [MITgcm-cvs] MITgcm/model/inc CVS Commit

[Michael Bates]

Hi Jean-Michel,

Thanks for the heads up!  I must admit I didn't test this new code as 
rigorously as normal before committing.  Sorry about that.

I'll fix up those mistakes and do as you suggest with u/vMean and 
taux/yEddy.

cheers,

Michael

On 09/16/2013 10:34 PM, Jean-Michel Campin wrote:
> Hi Michael,
>
> I see 2 problems in this recent check-in:
> 1) it's a good practice to add 1 line of description for any
>   variable in common block, like:
> C     etaN  :: free-surface r-anomaly (r unit) at current time level
>    Some people are reluctant to follow this rule, but it should not
>    prevent you to add this short description.
> 2) looks like uMean,vMean are correctly declared in DYNVARS.h
>   but they are not stored in any common block (so, they will be
>   local in all S/R). Strange to add these 2 fields in
>   pickup files if they are just local variables.
>
> And a comment:
> might be simpler to declare & add uMean,vMean in the same
> common block (and within the same #ifdef ALLOW_EDDYPSI) as
> tauxEddy,tauyEddy, instead of with other /DYNVARS_R/ variables.
>
> Cheers,
> Jean-Michel
>
> On Sun, Sep 15, 2013 at 10:29:32AM -0400, Michael Bates,54-1517,6172535458, wrote:
>> Update of /u/gcmpack/MITgcm/model/inc
>> In directory forge:/tmp/cvs-serv845
>>
>> Modified Files:
>> 	DYNVARS.h
>> Log Message:
>> New variables in common blocks for the eddy stress and the mean velocity.
>>
>> _______________________________________________
>> MITgcm-cvs mailing list
>> MITgcm-cvs at mitgcm.org
>> http://mitgcm.org/mailman/listinfo/mitgcm-cvs

-- 
Michael Bates
Postdoctoral Associate
Room 54-1517
Program in Atmospheres, Oceans and Climate
Department of Earth, Atmospheric and Planetary Sciences
Massachusetts Institute of Technology
Cambridge, MA 02139
USA
Ph: +1 617 253 5458