[MITgcm-devel] main_do_loop and DIVA

[Patrick Heimbach]

Hi Jean-Michel,

should be fixed.
There's a funny re-initialization of loadedRec block (not sure what this variable is for)
that I had missed, and for which there might be a better place to put it).
Right now I've (somewhat arbitrarily) put it back in main_do_loop,
but don't think it belongs there; I think it should go in forward_step.F

p.

On May 31, 2013, at 9:41 AM, Jean-Michel Campin <jmc at ocean.mit.edu> wrote:

> Hi Patrick,
> 
> AD experiment global_ocean.90x40x15 does not compile (with TAF),
> an error like missing declaration of bi,bj ?
> 
> And regarding DIVA test, could we talk next week ?
> 
> Cheers,
> Jean-Michel
> 
> On Thu, May 30, 2013 at 05:41:48PM -0400, Patrick Heimbach wrote:
>> Hi Matt (and Jean),
>> 
>> I've made another change to the_main_loop and main_do_loop.
>> In part, I've reverted the time-stepping which was mainly meant to enable revolve loop for OpenAD.
>> What's done now is that we keep the time-stepping loop in the_main_loop when using TAF
>> and have it in main_do_loop when using OpenAD (changes are actually rather minor, 
>> and perhaps even a bit less convoluted).
>> 
>> @ Matt: please take a look whether the fix allows you to build your config with latest
>> 
>> @ Jean: I tested the change with OpenAD on one of the verifications, seems to work fine, but might be worth double-checking
>> 
>> @ All: we should keep a verification experiment that tests DIVA.
>> Right now I've tested two: lab_sea (which was the closest to old natl_box_adjoint)
>> and global_ocean.cs32x15 (which is closest to new ECCO v4).
>> We'll need to make a decision of which config to use, and either modify an existing verif
>> or add a new one (since other compile/build options are needed).
>> 
>> Cheers
>> -Patrick
>> 
>> On May 17, 2013, at 12:35 PM, Matthew Mazloff <mmazloff at ucsd.edu> wrote:
>> 
>>> OK -- one hint is that it is opening level 4 tape files in the_main_loop -- so that is a problem if we want to start the divided loop in main_do_loop
>>> 
>>> the ordering is definitely off...
>>> 
>>> I will get back to this later -- have to run now -- but it looks like we may have to move some tape calls…
>>> 
>>> if you have any suggestions I would greatly appreciate it!
>>> 
>>> Matt
>>> 
>>> 
>>> 
>>> On May 17, 2013, at 9:07 AM, Matthew Mazloff <mmazloff at ucsd.edu> wrote:
>>> 
>>>> Hi Patrick
>>>> 
>>>> For some reason TAF is ignoring the 
>>>> 
>>>> CADJ loop = divided
>>>> 
>>>> statement in main_do_loop.F
>>>> 
>>>> Has anyone else seen this issue - does it have to do with my staf options. (It was working fine before in the_main_loop.F.)
>>>> 
>>>> Or is it just a TAF bug and I need to email them
>>>> 
>>>> Thanks for your help
>>>> Matt
>>>> 
>>>> 
>>>> 
>>>> _______________________________________________
>>>> MITgcm-devel mailing list
>>>> MITgcm-devel at mitgcm.org
>>>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>>> 
>>> 
>>> _______________________________________________
>>> MITgcm-devel mailing list
>>> MITgcm-devel at mitgcm.org
>>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>> 
>> 
>> ---
>> Patrick Heimbach | heimbach at mit.edu | http://www.mit.edu/~heimbach
>> MIT | EAPS 54-1420 | 77 Massachusetts Ave | Cambridge MA 02139 USA
>> FON +1-617-253-5259 | FAX +1-617-253-4464 | SKYPE patrick.heimbach
>> 
> 
> 
> 
>> _______________________________________________
>> MITgcm-devel mailing list
>> MITgcm-devel at mitgcm.org
>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
> 
> 
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel


---
Patrick Heimbach | heimbach at mit.edu | http://www.mit.edu/~heimbach
MIT | EAPS 54-1420 | 77 Massachusetts Ave | Cambridge MA 02139 USA
FON +1-617-253-5259 | FAX +1-617-253-4464 | SKYPE patrick.heimbach

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1588 bytes
Desc: not available
URL: <http://mitgcm.org/pipermail/mitgcm-devel/attachments/20130531/7e52fe20/attachment-0001.p7s>