[MITgcm-devel] Fwd: modified code

[Jean-Michel Campin]

Hi Patrick,

I understand your point and agree.
What about renaming the_loop_body.F --> main_do_loop.F ?
to remember that the iteration loop is done there

Cheers,
Jean-Michel

On Tue, Feb 19, 2013 at 05:46:52PM -0500, Patrick Heimbach wrote:
> 
> If we change the name of the top-level routine for the AD tool (for either TAF
> or OpenAD) we will need to change many more files (e.g., all files in
> tools/adjoint_options/ )
> so I'd rather not do that, it's disruptive and potential issues with backward
> compatibilities.
> 
> If you have a better name for "the_loop_body.F" that's no problem.
> 
> p.
> 
> Quoting Jean-Michel Campin <jmc at ocean.mit.edu>:
> 
> >Hi Patrick,
> >
> >I don't have much to say. If you  checked that it's working
> >well with TAF and with OpenAD, it's all good.
> >
> >One detail (just a matter of name), might have been little bit more
> >clear to keep the main iteration loop into the "the_main_loop.F"
> >and to get a new name for the outside routine (instead of a new name
> >for the inside routine).
> >
> >Cheers,
> >Jean-Michel
> >
> >On Tue, Feb 19, 2013 at 02:32:06PM -0500, Patrick Heimbach wrote:
> >>
> >>Hi Jean-Michel,
> >>
> >>I've attached three files that contain a slight reorganization
> >>of the_main_loop.F Since they affect the top-level structure I
> >>refrained from checking them into cvs before double-checking
> >>with you.
> >>
> >>This re-organization seems rather trivial but it addresses a
> >>very important improvement for using OpenAD. Let me know if you
> >>see an issue *not* to reorganize the_main_loop in this way.
> >>
> >>Cheers
> >>-p.
> >>
> >>PS:
> >>Very strange down here.
> >>Sun goes the wrong way, cars drive the wrong way, people talk
> >>funny, and too warm for snow.
> >>But good (local!) beer...
> >>
> >>
> >>
> >>Begin forwarded message:
> >>
> >>> From: Patrick Heimbach <heimbach at mit.edu>
> >>> Subject: modified code
> >>> Date: February 12, 2013 10:46:22 AM EST
> >>> To: Jean Utke <utke at mcs.anl.gov>
> >>>
> >>>
> >>> There are 3 files to be replaced in directory model/src/
> >>> The one you're interested in is the_loop_body.F
> >>> Can you give it a try?
> >>> -Patrick
> >>>
> >
> >
> >>>
> >>>
> >>> ---
> >>> Patrick Heimbach | heimbach at mit.edu | http://www.mit.edu/~heimbach
> >>> MIT | EAPS 54-1420 | 77 Massachusetts Ave | Cambridge MA 02139 USA
> >>> FON +1-617-253-5259 | FAX +1-617-253-4464 | SKYPE patrick.heimbach
> >>
> >>
> >
> >
> >
> >
> >>_______________________________________________
> >>MITgcm-devel mailing list
> >>MITgcm-devel at mitgcm.org
> >>http://mitgcm.org/mailman/listinfo/mitgcm-devel
> >
> >
> >_______________________________________________
> >MITgcm-devel mailing list
> >MITgcm-devel at mitgcm.org
> >http://mitgcm.org/mailman/listinfo/mitgcm-devel
> >
> 
> 
> 
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel