[MITgcm-devel] [MITgcm-cvs] MITgcm/pkg/exf CVS Commit

[Jean-Michel Campin]

Hi Dimitris,

I have 2 comments related to thi new feature (ALLOW_RUNOFTEMP) you added:
1) it would have been nice to make it compatible with what I addeed
  recently (when setting temp_EvPrRn to use an Energy Reference Level).
  From what I see in exf_mapfields.F, the treatment of the case 
> IF ( temp_EvPrRn .NE. UNSET_RL )
  is ignored when ALLOW_RUNOFTEMP is defined.
  I would recommand, if you leave exf_mapfields.F as it is now,
  to add a stop in exf_check.F:
> #ifdef ALLOW_RUNOFTEMP 
>  IF ( temp_EvPrRn .NE. UNSET_RL ) STOP
> #endif

  And from my point of view, I don't really like the updated comment:
C     4) By default, RunOff comes at the temp of surface water (with same Cp);
C        ifdef ALLOW_RUNOFTEMP, RunOff temp can be specified in runoftempfile.
 since I have the impression that it does not apply to the case
 where temp_EvPrRn is defined (as opposed to comments 1,2,3 & 5)
2) I am comfused with the sign of the term you added to Qnet.
 Could you check again ?

Cheers,
Jean-Michel

On Tue, Apr 23, 2013 at 03:04:34PM -0400, Dimitris Menemenlis wrote:
> Update of /u/gcmpack/MITgcm/pkg/exf
> In directory forge:/tmp/cvs-serv22899
> 
> Modified Files:
> 	EXF_FIELDS.h EXF_OPTIONS.h EXF_PARAM.h exf_check_range.F 
> 	exf_diagnostics_fill.F exf_diagnostics_init.F exf_getffields.F 
> 	exf_init.F exf_mapfields.F exf_monitor.F exf_readparms.F 
> 	exf_summary.F 
> Log Message:
> adding ALLOW_RUNOFTEMP for specifying temperature of runoff
> Modified Files: EXF_FIELDS.h EXF_OPTIONS.h EXF_PARAM.h exf_check_range.F 
>   exf_diagnostics_fill.F exf_diagnostics_init.F exf_getffields.F 
>   exf_init.F exf_mapfields.F exf_monitor.F exf_readparms.F exf_summary.F 
> 
> 
> _______________________________________________
> MITgcm-cvs mailing list
> MITgcm-cvs at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-cvs