[MITgcm-devel] pkg/cal cleaning

Wed Apr 4 15:59:08 EDT 2012

Jean-Michel, what you suggest below is fine with me.
I don't think that I have ever used any of those routines.

One question I have is whether it is possible to do the changes that you have in
mind while keeping the user interface, the CPP options and the runtime parameters unchanged?

Cheers

Dimitris Menemenlis

On Apr 4, 2012, at 12:43 PM, Jean-Michel Campin wrote:

> Hi Patrick and others,
> 
> I was thinking of cleaning a little bit pkg/cal, to have 
> better checking (and stop) before something wrong happen.
> 
> One thing I noticed was that several subroutines are never called:
> cal_daysformonth.F
> cal_dayspermonth.F
> cal_monthsforyear.F
> cal_monthsperyear.F
> cal_stepsforday.F
> cal_stepsperday.F
> cal_weekday.F
> Usually, it's not a problem to have routine which are not called,
> but regarding pkg/cal, I am not confident in using these routines
> (if needed) since they have not been tested for a long time.
> And it does not help for cleaning up the pkg to have untested
> and unused pieces of code.
> So, if every one agree, I would be in favor of removing these
> unused subroutines.
> 
> Cheers,
> Jean-Michel
> 
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel